History

drm/uapi: Deprecate nonsense kms mode types

BUILTIN, CRTC_C, CLOCK_C, and DEFULT mode types are unused. Let's refuse to generate them or accept them from userspace either. A cursory check didn't reveal any userspace code that would depend on these. v2: Recommend DRIVER instead of BUILTIN (ajax)

Ville Syrjälä committed 9 years ago

Commit b7245cc1 parent 538af6c2 files · +9 −12Browse files

Showing the changes to include/uapi (1 of 2 files). Show all

Unified · Split

include/uapi/drm/drm_mode.h+5−9
@@ -38,19 +38,15 @@ extern "C" { · 37 unmodified lines
38#define DRM_DISPLAY_MODE_LEN 3238#define DRM_DISPLAY_MODE_LEN 32
39#define DRM_PROP_NAME_LEN 3239#define DRM_PROP_NAME_LEN 32
40 40
41#define DRM_MODE_TYPE_BUILTIN (1<<0)41#define DRM_MODE_TYPE_BUILTIN (1<<0) /* deprecated */
42#define DRM_MODE_TYPE_CLOCK_C ((1<<1) | DRM_MODE_TYPE_BUILTIN)42#define DRM_MODE_TYPE_CLOCK_C ((1<<1) | DRM_MODE_TYPE_BUILTIN) /* deprecated */
43#define DRM_MODE_TYPE_CRTC_C ((1<<2) | DRM_MODE_TYPE_BUILTIN)43#define DRM_MODE_TYPE_CRTC_C ((1<<2) | DRM_MODE_TYPE_BUILTIN) /* deprecated */
44#define DRM_MODE_TYPE_PREFERRED (1<<3)44#define DRM_MODE_TYPE_PREFERRED (1<<3)
45#define DRM_MODE_TYPE_DEFAULT (1<<4)45#define DRM_MODE_TYPE_DEFAULT (1<<4) /* deprecated */
46#define DRM_MODE_TYPE_USERDEF (1<<5)46#define DRM_MODE_TYPE_USERDEF (1<<5)
47#define DRM_MODE_TYPE_DRIVER (1<<6)47#define DRM_MODE_TYPE_DRIVER (1<<6)
48 48
49#define DRM_MODE_TYPE_ALL (DRM_MODE_TYPE_BUILTIN | \49#define DRM_MODE_TYPE_ALL (DRM_MODE_TYPE_PREFERRED | \
50 DRM_MODE_TYPE_CLOCK_C | \
51 DRM_MODE_TYPE_CRTC_C | \
52 DRM_MODE_TYPE_PREFERRED | \
53 DRM_MODE_TYPE_DEFAULT | \
54 DRM_MODE_TYPE_USERDEF | \50 DRM_MODE_TYPE_USERDEF | \
55 DRM_MODE_TYPE_DRIVER)51 DRM_MODE_TYPE_DRIVER)
56 52

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t