It seems there are more and more uses of "if (!ptr)" in preference to "if (ptr == NULL)" so add a --strict test to emit a message when using the latter form. This also finds (ptr != NULL). Fix it too if desired.
Showing the changes to scripts/checkpatch.pl (1 of 1 file). Show all
Unified · Split
| @@ -4522,6 +4522,20 @@ sub process { · 4521 unmodified lines | ||
| 4522 | 4522 | "Possible precedence defect with mask then right shift - may need parentheses\n" . $herecurr); |
| 4523 | 4523 | } |
| 4524 | 4524 | |
| 4525 | +# check for pointer comparisons to NULL | |
| 4526 | + if ($^V && $^V ge 5.10.0) { | |
| 4527 | + while ($line =~ /\b$LvalOrFunc\s*(==|\!=)\s*NULL\b/g) { | |
| 4528 | + my $val = $1; | |
| 4529 | + my $equal = "!"; | |
| 4530 | + $equal = "" if ($4 eq "!="); | |
| 4531 | + if (CHK("COMPARISON_TO_NULL", | |
| 4532 | + "Comparison to NULL could be written \"${equal}${val}\"\n" . $herecurr) && | |
| 4533 | + $fix) { | |
| 4534 | + $fixed[$fixlinenr] =~ s/\b\Q$val\E\s*(?:==|\!=)\s*NULL\b/$equal$val/; | |
| 4535 | + } | |
| 4536 | + } | |
| 4537 | + } | |
| 4538 | + | |
| 4525 | 4539 | # check for bad placement of section $InitAttribute (e.g.: __initdata) |
| 4526 | 4540 | if ($line =~ /(\b$InitAttribute\b)/) { |
| 4527 | 4541 | my $attr = $1; |