History

drm/xe/xe_exec_queue: Add check for access counter granularity

Add conditional check for access counter granularity. This check will return -EINVAL if granularity is beyond 64M which is a hardware limitation. v2: Defined XE_ACC_GRANULARITY_128K 0 XE_ACC_GRANULARITY_2M 1 XE_ACC_GRANULARITY_16M 2 XE_ACC_GRANULARITY_64M 3 as part of uAPI. So, that user can also use it.(Oak) v3: Move uAPI to proper location and give proper documentation.(Brian, Oak)

Priyanka Dandamudi committed 3 years ago

Commit b8d70701 parent 65e95732 files · +17 −0Browse files

Unified · Split

2 files
  1. drivers/gpu/drm/xe/xe_exec_queue.c +3 −0
  2. include/uapi/drm/xe_drm.h +14 −0
drivers/gpu/drm/xe/xe_exec_queue.c+3−0
@@ -393,6 +393,9 @@ static int exec_queue_set_acc_granularity(struct xe_device *xe, struct xe_exec_q · 392 unmodified lines
393393 if (XE_IOCTL_DBG(xe, !xe->info.supports_usm))
394394 return -EINVAL;
395395
396+ if (value > XE_ACC_GRANULARITY_64M)
397+ return -EINVAL;
398+
396399 q->usm.acc_granularity = value;
397400
398401 return 0;
include/uapi/drm/xe_drm.h+14−0
@@ -731,6 +731,20 @@ struct drm_xe_vm_bind { · 730 unmodified lines
731731 __u64 reserved[2];
732732 };
733733
734+/* For use with XE_EXEC_QUEUE_SET_PROPERTY_ACC_GRANULARITY */
735+
736+/* Monitor 128KB contiguous region with 4K sub-granularity */
737+#define XE_ACC_GRANULARITY_128K 0
738+
739+/* Monitor 2MB contiguous region with 64KB sub-granularity */
740+#define XE_ACC_GRANULARITY_2M 1
741+
742+/* Monitor 16MB contiguous region with 512KB sub-granularity */
743+#define XE_ACC_GRANULARITY_16M 2
744+
745+/* Monitor 64MB contiguous region with 2M sub-granularity */
746+#define XE_ACC_GRANULARITY_64M 3
747+
734748 /**
735749 * struct drm_xe_exec_queue_set_property - exec queue set property
736750 *

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t