History

kconfig: gconf: refactor replace_button_icon()

The "window" and "style" arguments for replace_button_icon() are now unused. Remove them and refactor the function accordingly.

Masahiro Yamada committed 1 year ago

Commit b8f660a1 parent 9517f471 file · +5 −15Browse files

Unified · Split

scripts/kconfig/gconf.c+5−15
@@ -1100,21 +1100,17 @@ static void fixup_rootmenu(struct menu *menu) · 1099 unmodified lines
11001100 }
11011101
11021102 /* Main Window Initialization */
1103−static void replace_button_icon(GladeXML *xml, GdkDrawable *window,
1104− GtkStyle *style, gchar *btn_name, gchar **xpm)
1103+static void replace_button_icon(GtkWidget *widget, const char * const xpm[])
11051104 {
11061105 GdkPixbuf *pixbuf;
11071106 GtkWidget *image;
1108− GtkToolButton *button;
11091107
11101108 pixbuf = gdk_pixbuf_new_from_xpm_data((const char **)xpm);
11111109 image = gtk_image_new_from_pixbuf(pixbuf);
11121110 g_object_unref(pixbuf);
11131111
1114− button = GTK_TOOL_BUTTON(glade_xml_get_widget(xml, btn_name));
1115−
11161112 gtk_widget_show(image);
1117− gtk_tool_button_set_icon_widget(button, image);
1113+ gtk_tool_button_set_icon_widget(GTK_TOOL_BUTTON(widget), image);
11181114 }
11191115
11201116 static void init_main_window(const gchar *glade_file)
@@ -1122,7 +1118,6 @@ static void init_main_window(const gchar *glade_file) · 1 unmodified line
11221118 GladeXML *xml;
11231119 GtkWidget *widget;
11241120 GtkTextBuffer *txtbuf;
1125− GtkStyle *style;
11261121
11271122 xml = glade_xml_new(glade_file, "window1", NULL);
11281123 if (!xml)
@@ -1229,25 +1224,20 @@ static void init_main_window(const gchar *glade_file) · 100 unmodified lines
12291224 g_signal_connect(save_btn, "clicked",
12301225 G_CALLBACK(on_save_clicked), NULL);
12311226
1232− style = gtk_widget_get_style(main_wnd);
1233−
12341227 single_btn = glade_xml_get_widget(xml, "button4");
12351228 g_signal_connect(single_btn, "clicked",
12361229 G_CALLBACK(on_single_clicked), NULL);
1237− replace_button_icon(xml, main_wnd->window, style,
1238− "button4", (gchar **) xpm_single_view);
1230+ replace_button_icon(single_btn, xpm_single_view);
12391231
12401232 split_btn = glade_xml_get_widget(xml, "button5");
12411233 g_signal_connect(split_btn, "clicked",
12421234 G_CALLBACK(on_split_clicked), NULL);
1243− replace_button_icon(xml, main_wnd->window, style,
1244− "button5", (gchar **) xpm_split_view);
1235+ replace_button_icon(split_btn, xpm_split_view);
12451236
12461237 full_btn = glade_xml_get_widget(xml, "button6");
12471238 g_signal_connect(full_btn, "clicked",
12481239 G_CALLBACK(on_full_clicked), NULL);
1249− replace_button_icon(xml, main_wnd->window, style,
1250− "button6", (gchar **) xpm_tree_view);
1240+ replace_button_icon(full_btn, xpm_tree_view);
12511241
12521242 widget = glade_xml_get_widget(xml, "button7");
12531243 g_signal_connect(widget, "clicked",