This reverts commit 367c820ef08082e68df8a3bc12e62393af21e4b5. lockup_detector_init() makes heavy use of per-cpu variables and must be called with preemption disabled. Usually, it's handled early during boot in kernel_init_freeable(), before SMP has been initialised. Since we do not know whether or not our PMU interrupt can be signalled as an NMI until considerably later in the boot process, the Arm PMU driver attempts to re-initialise the lockup detector off the back of a device_initcall(). Unfortunately, this is called from preemptible context and results in the following splat: | BUG: using smp_processor_id() in preemptible [00000000] code: swapper/0/1 | caller is debug_smp_processor_id+0x20/0x2c | CPU: 2 PID: 1 Comm: swapper/0 Not tainted 5.10.0+ #276 | Hardware name: linux,dummy-virt (DT) | Call trace: | dump_backtrace+0x0/0x3c0 | show_stack+0x20/0x6c | dump_stack+0x2f0/0x42c | check_preemption_disabled+0x1cc/0x1dc | debug_smp_processor_id+0x20/0x2c | hardlockup_detector_event_create+0x34/0x18c | hardlockup_detector_perf_init+0x2c/0x134 | watchdog_nmi_probe+0x18/0x24 | lockup_detector_init+0x44/0xa8 | armv8_pmu_driver_init+0x54/0x78 | do_one_initcall+0x184/0x43c | kernel_init_freeable+0x368/0x380 | kernel_init+0x1c/0x1cc | ret_from_fork+0x10/0x30 Rather than bodge this with raw_smp_processor_id() or randomly disabling preemption, simply revert the culprit for now until we figure out how to do this properly.
Unified · Split
| @@ -174,8 +174,6 @@ config ARM64 · 173 unmodified lines | |||
| 174 | select HAVE_NMI | 174 | select HAVE_NMI |
| 175 | select HAVE_PATA_PLATFORM | 175 | select HAVE_PATA_PLATFORM |
| 176 | select HAVE_PERF_EVENTS | 176 | select HAVE_PERF_EVENTS |
| 177 | select HAVE_PERF_EVENTS_NMI if ARM64_PSEUDO_NMI && HW_PERF_EVENTS | ||
| 178 | select HAVE_HARDLOCKUP_DETECTOR_PERF if PERF_EVENTS && HAVE_PERF_EVENTS_NMI | ||
| 179 | select HAVE_PERF_REGS | 177 | select HAVE_PERF_REGS |
| 180 | select HAVE_PERF_USER_STACK_DUMP | 178 | select HAVE_PERF_USER_STACK_DUMP |
| 181 | select HAVE_REGS_AND_STACK_ACCESS_API | 179 | select HAVE_REGS_AND_STACK_ACCESS_API |
| @@ -23,8 +23,6 @@ · 22 unmodified lines | |||
| 23 | #include <linux/platform_device.h> | 23 | #include <linux/platform_device.h> |
| 24 | #include <linux/sched_clock.h> | 24 | #include <linux/sched_clock.h> |
| 25 | #include <linux/smp.h> | 25 | #include <linux/smp.h> |
| 26 | #include <linux/nmi.h> | ||
| 27 | #include <linux/cpufreq.h> | ||
| 28 | 26 | ||
| 29 | /* ARMv8 Cortex-A53 specific event types. */ | 27 | /* ARMv8 Cortex-A53 specific event types. */ |
| 30 | #define ARMV8_A53_PERFCTR_PREF_LINEFILL 0xC2 | 28 | #define ARMV8_A53_PERFCTR_PREF_LINEFILL 0xC2 |
| @@ -1250,21 +1248,10 @@ static struct platform_driver armv8_pmu_driver = { · 1219 unmodified lines | |||
| 1250 | 1248 | ||
| 1251 | static int __init armv8_pmu_driver_init(void) | 1249 | static int __init armv8_pmu_driver_init(void) |
| 1252 | { | 1250 | { |
| 1253 | int ret; | ||
| 1254 | |||
| 1255 | if (acpi_disabled) | 1251 | if (acpi_disabled) |
| 1256 | ret = platform_driver_register(&armv8_pmu_driver); | 1252 | return platform_driver_register(&armv8_pmu_driver); |
| 1257 | else | 1253 | else |
| 1258 | ret = arm_pmu_acpi_probe(armv8_pmuv3_init); | 1254 | return arm_pmu_acpi_probe(armv8_pmuv3_init); |
| 1259 | |||
| 1260 | /* | ||
| 1261 | * Try to re-initialize lockup detector after PMU init in | ||
| 1262 | * case PMU events are triggered via NMIs. | ||
| 1263 | */ | ||
| 1264 | if (ret == 0 && arm_pmu_irq_is_nmi()) | ||
| 1265 | lockup_detector_init(); | ||
| 1266 | |||
| 1267 | return ret; | ||
| 1268 | } | 1255 | } |
| 1269 | device_initcall(armv8_pmu_driver_init) | 1256 | device_initcall(armv8_pmu_driver_init) |
| 1270 | 1257 | ||
| @@ -1322,27 +1309,3 @@ void arch_perf_update_userpage(struct perf_event *event, · 51 unmodified lines | |||
| 1322 | userpg->cap_user_time_zero = 1; | 1309 | userpg->cap_user_time_zero = 1; |
| 1323 | userpg->cap_user_time_short = 1; | 1310 | userpg->cap_user_time_short = 1; |
| 1324 | } | 1311 | } |
| 1325 | |||
| 1326 | #ifdef CONFIG_HARDLOCKUP_DETECTOR_PERF | ||
| 1327 | /* | ||
| 1328 | * Safe maximum CPU frequency in case a particular platform doesn't implement | ||
| 1329 | * cpufreq driver. Although, architecture doesn't put any restrictions on | ||
| 1330 | * maximum frequency but 5 GHz seems to be safe maximum given the available | ||
| 1331 | * Arm CPUs in the market which are clocked much less than 5 GHz. On the other | ||
| 1332 | * hand, we can't make it much higher as it would lead to a large hard-lockup | ||
| 1333 | * detection timeout on parts which are running slower (eg. 1GHz on | ||
| 1334 | * Developerbox) and doesn't possess a cpufreq driver. | ||
| 1335 | */ | ||
| 1336 | #define SAFE_MAX_CPU_FREQ 5000000000UL // 5 GHz | ||
| 1337 | u64 hw_nmi_get_sample_period(int watchdog_thresh) | ||
| 1338 | { | ||
| 1339 | unsigned int cpu = smp_processor_id(); | ||
| 1340 | unsigned long max_cpu_freq; | ||
| 1341 | |||
| 1342 | max_cpu_freq = cpufreq_get_hw_max_freq(cpu) * 1000UL; | ||
| 1343 | if (!max_cpu_freq) | ||
| 1344 | max_cpu_freq = SAFE_MAX_CPU_FREQ; | ||
| 1345 | |||
| 1346 | return (u64)max_cpu_freq * watchdog_thresh; | ||
| 1347 | } | ||
| 1348 | #endif | ||
| @@ -726,11 +726,6 @@ static int armpmu_get_cpu_irq(struct arm_pmu *pmu, int cpu) · 725 unmodified lines | |||
| 726 | return per_cpu(hw_events->irq, cpu); | 726 | return per_cpu(hw_events->irq, cpu); |
| 727 | } | 727 | } |
| 728 | 728 | ||
| 729 | bool arm_pmu_irq_is_nmi(void) | ||
| 730 | { | ||
| 731 | return has_nmi; | ||
| 732 | } | ||
| 733 | |||
| 734 | /* | 729 | /* |
| 735 | * PMU hardware loses all context when a CPU goes offline. | 730 | * PMU hardware loses all context when a CPU goes offline. |
| 736 | * When a CPU is hotplugged back in, since some hardware registers are | 731 | * When a CPU is hotplugged back in, since some hardware registers are |
| @@ -163,8 +163,6 @@ int arm_pmu_acpi_probe(armpmu_init_fn init_fn); · 162 unmodified lines | |||
| 163 | static inline int arm_pmu_acpi_probe(armpmu_init_fn init_fn) { return 0; } | 163 | static inline int arm_pmu_acpi_probe(armpmu_init_fn init_fn) { return 0; } |
| 164 | #endif | 164 | #endif |
| 165 | 165 | ||
| 166 | bool arm_pmu_irq_is_nmi(void); | ||
| 167 | |||
| 168 | /* Internal functions only for core arm_pmu code */ | 166 | /* Internal functions only for core arm_pmu code */ |
| 169 | struct arm_pmu *armpmu_alloc(void); | 167 | struct arm_pmu *armpmu_alloc(void); |
| 170 | struct arm_pmu *armpmu_alloc_atomic(void); | 168 | struct arm_pmu *armpmu_alloc_atomic(void); |