This patch adds complimentary DMA_BUF_SET_NAME ioctls, which lets userspace processes attach a free-form name to each buffer. This information can be extremely helpful for tracking and accounting shared buffers. For example, on Android, we know what each buffer will be used for at allocation time: GL, multimedia, camera, etc. The userspace allocator can use DMA_BUF_SET_NAME to associate that information with the buffer, so we can later give developers a breakdown of how much memory they're allocating for graphics, camera, etc.
Showing the changes to include/linux (1 of 3 files). Show all
Unified · Split
| @@ -280,10 +280,12 @@ struct dma_buf_ops { · 279 unmodified lines | |||
| 280 | * @file: file pointer used for sharing buffers across, and for refcounting. | 280 | * @file: file pointer used for sharing buffers across, and for refcounting. |
| 281 | * @attachments: list of dma_buf_attachment that denotes all devices attached. | 281 | * @attachments: list of dma_buf_attachment that denotes all devices attached. |
| 282 | * @ops: dma_buf_ops associated with this buffer object. | 282 | * @ops: dma_buf_ops associated with this buffer object. |
| 283 | * @lock: used internally to serialize list manipulation, attach/detach and vmap/unmap | 283 | * @lock: used internally to serialize list manipulation, attach/detach and |
| 284 | * vmap/unmap, and accesses to name | ||
| 284 | * @vmapping_counter: used internally to refcnt the vmaps | 285 | * @vmapping_counter: used internally to refcnt the vmaps |
| 285 | * @vmap_ptr: the current vmap ptr if vmapping_counter > 0 | 286 | * @vmap_ptr: the current vmap ptr if vmapping_counter > 0 |
| 286 | * @exp_name: name of the exporter; useful for debugging. | 287 | * @exp_name: name of the exporter; useful for debugging. |
| 288 | * @name: userspace-provided name; useful for accounting and debugging. | ||
| 287 | * @owner: pointer to exporter module; used for refcounting when exporter is a | 289 | * @owner: pointer to exporter module; used for refcounting when exporter is a |
| 288 | * kernel module. | 290 | * kernel module. |
| 289 | * @list_node: node for dma_buf accounting and debugging. | 291 | * @list_node: node for dma_buf accounting and debugging. |
| @@ -311,6 +313,7 @@ struct dma_buf { · 21 unmodified lines | |||
| 311 | unsigned vmapping_counter; | 313 | unsigned vmapping_counter; |
| 312 | void *vmap_ptr; | 314 | void *vmap_ptr; |
| 313 | const char *exp_name; | 315 | const char *exp_name; |
| 316 | const char *name; | ||
| 314 | struct module *owner; | 317 | struct module *owner; |
| 315 | struct list_head list_node; | 318 | struct list_head list_node; |
| 316 | void *priv; | 319 | void *priv; |