History

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc

Pull sparc fix from David Miller: "A use-before-NULL-check from Dan Carpenter" * git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc: dbri: move dereference after check for NULL

Linus Torvalds committed 9 years ago

Commit bc3913a2 parents da1b466 163117e1 file · +2 −1Browse files

Unified · Split

sound/sparc/dbri.c+2−1
@@ -1702,7 +1702,7 @@ interrupts are disabled. · 1701 unmodified lines
17021702 static void xmit_descs(struct snd_dbri *dbri)
17031703 {
17041704 struct dbri_streaminfo *info;
1705− u32 dvma_addr = (u32)dbri->dma_dvma;
1705+ u32 dvma_addr;
17061706 s32 *cmd;
17071707 unsigned long flags;
17081708 int first_td;
@@ -1710,6 +1710,7 @@ static void xmit_descs(struct snd_dbri *dbri) · 1 unmodified line
17101710 if (dbri == NULL)
17111711 return; /* Disabled */
17121712
1713+ dvma_addr = (u32)dbri->dma_dvma;
17131714 info = &dbri->stream_info[DBRI_REC];
17141715 spin_lock_irqsave(&dbri->lock, flags);
17151716