There is a misconception about what "insert_failed" means. We increment this even when a clash got resolved, so it might not indicate a problem. Add a dedicated counter for clash resolution and only increment insert_failed if a clash cannot be resolved. For the old /proc interface, export this in place of an older stat that got removed a while back. For ctnetlink, export this with a new attribute. Also correct an outdated comment that implies we add a duplicate tuple -- we only add the (unique) reply direction.
Showing the changes to include/uapi (1 of 5 files). Show all
Unified · Split
| @@ -256,6 +256,7 @@ enum ctattr_stats_cpu { · 255 unmodified lines | |||
| 256 | CTA_STATS_EARLY_DROP, | 256 | CTA_STATS_EARLY_DROP, |
| 257 | CTA_STATS_ERROR, | 257 | CTA_STATS_ERROR, |
| 258 | CTA_STATS_SEARCH_RESTART, | 258 | CTA_STATS_SEARCH_RESTART, |
| 259 | CTA_STATS_CLASH_RESOLVE, | ||
| 259 | __CTA_STATS_MAX, | 260 | __CTA_STATS_MAX, |
| 260 | }; | 261 | }; |
| 261 | #define CTA_STATS_MAX (__CTA_STATS_MAX - 1) | 262 | #define CTA_STATS_MAX (__CTA_STATS_MAX - 1) |