History

ALSA: oxygen: constify snd_pcm_ops structures

Check for snd_pcm_ops structures that are only stored in the ops field of a snd_soc_platform_driver structure or passed as the third argument to snd_pcm_set_ops. The corresponding field or parameter is declared const, so snd_pcm_ops structures that have this property can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct snd_pcm_ops i@p = { ... }; @ok1@ identifier r.i; struct snd_soc_platform_driver e; position p; @@ e.ops = &i@p; @ok2@ identifier r.i; expression e1, e2; position p; @@ snd_pcm_set_ops(e1, e2, &i@p) @bad@ position p != {r.p,ok1.p,ok2.p}; identifier r.i; struct snd_pcm_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct snd_pcm_ops i = { ... }; // </smpl>

Julia Lawall committed 10 years ago

Commit bc9a9101 parent d602efc1 file · +6 −6Browse files

Unified · Split

sound/pci/oxygen/oxygen_pcm.c+6−6
@@ -631,7 +631,7 @@ static snd_pcm_uframes_t oxygen_pointer(struct snd_pcm_substream *substream) · 630 unmodified lines
631 return bytes_to_frames(runtime, curr_addr - (u32)runtime->dma_addr);631 return bytes_to_frames(runtime, curr_addr - (u32)runtime->dma_addr);
632}632}
633 633
634static struct snd_pcm_ops oxygen_rec_a_ops = {634static const struct snd_pcm_ops oxygen_rec_a_ops = {
635 .open = oxygen_rec_a_open,635 .open = oxygen_rec_a_open,
636 .close = oxygen_close,636 .close = oxygen_close,
637 .ioctl = snd_pcm_lib_ioctl,637 .ioctl = snd_pcm_lib_ioctl,
@@ -642,7 +642,7 @@ static struct snd_pcm_ops oxygen_rec_a_ops = { · 4 unmodified lines
642 .pointer = oxygen_pointer,642 .pointer = oxygen_pointer,
643};643};
644 644
645static struct snd_pcm_ops oxygen_rec_b_ops = {645static const struct snd_pcm_ops oxygen_rec_b_ops = {
646 .open = oxygen_rec_b_open,646 .open = oxygen_rec_b_open,
647 .close = oxygen_close,647 .close = oxygen_close,
648 .ioctl = snd_pcm_lib_ioctl,648 .ioctl = snd_pcm_lib_ioctl,
@@ -653,7 +653,7 @@ static struct snd_pcm_ops oxygen_rec_b_ops = { · 4 unmodified lines
653 .pointer = oxygen_pointer,653 .pointer = oxygen_pointer,
654};654};
655 655
656static struct snd_pcm_ops oxygen_rec_c_ops = {656static const struct snd_pcm_ops oxygen_rec_c_ops = {
657 .open = oxygen_rec_c_open,657 .open = oxygen_rec_c_open,
658 .close = oxygen_close,658 .close = oxygen_close,
659 .ioctl = snd_pcm_lib_ioctl,659 .ioctl = snd_pcm_lib_ioctl,
@@ -664,7 +664,7 @@ static struct snd_pcm_ops oxygen_rec_c_ops = { · 4 unmodified lines
664 .pointer = oxygen_pointer,664 .pointer = oxygen_pointer,
665};665};
666 666
667static struct snd_pcm_ops oxygen_spdif_ops = {667static const struct snd_pcm_ops oxygen_spdif_ops = {
668 .open = oxygen_spdif_open,668 .open = oxygen_spdif_open,
669 .close = oxygen_close,669 .close = oxygen_close,
670 .ioctl = snd_pcm_lib_ioctl,670 .ioctl = snd_pcm_lib_ioctl,
@@ -675,7 +675,7 @@ static struct snd_pcm_ops oxygen_spdif_ops = { · 4 unmodified lines
675 .pointer = oxygen_pointer,675 .pointer = oxygen_pointer,
676};676};
677 677
678static struct snd_pcm_ops oxygen_multich_ops = {678static const struct snd_pcm_ops oxygen_multich_ops = {
679 .open = oxygen_multich_open,679 .open = oxygen_multich_open,
680 .close = oxygen_close,680 .close = oxygen_close,
681 .ioctl = snd_pcm_lib_ioctl,681 .ioctl = snd_pcm_lib_ioctl,
@@ -686,7 +686,7 @@ static struct snd_pcm_ops oxygen_multich_ops = { · 4 unmodified lines
686 .pointer = oxygen_pointer,686 .pointer = oxygen_pointer,
687};687};
688 688
689static struct snd_pcm_ops oxygen_ac97_ops = {689static const struct snd_pcm_ops oxygen_ac97_ops = {
690 .open = oxygen_ac97_open,690 .open = oxygen_ac97_open,
691 .close = oxygen_close,691 .close = oxygen_close,
692 .ioctl = snd_pcm_lib_ioctl,692 .ioctl = snd_pcm_lib_ioctl,

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t