History

dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller

The Socionext interrupt controller internal to the the PCI block isn't documented which causes warnings when unevaluatedProperties check is also fixed. Add the 'interrupt-controller' child node and properties and fixup the example so that interrupt properties can be parsed.

Rob Herring committed 4 years ago

Commit bcd7ec21 parent cdc46fa1 file · +22 −1Browse files

Unified · Split

Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml+22−1
@@ -51,6 +51,19 @@ properties: · 50 unmodified lines
51 phy-names:51 phy-names:
52 const: pcie-phy52 const: pcie-phy
53 53
54 interrupt-controller:
55 type: object
56 additionalProperties: false
57
58 properties:
59 interrupt-controller: true
60
61 '#interrupt-cells':
62 const: 1
63
64 interrupts:
65 maxItems: 1
66
54required:67required:
55 - compatible68 - compatible
56 - reg69 - reg
@@ -62,6 +75,13 @@ unevaluatedProperties: false · 5 unmodified lines
62 75
63examples:76examples:
64 - |77 - |
78 bus {
79 gic: interrupt-controller {
80 interrupt-controller;
81 #interrupt-cells = <3>;
82 };
83 };
84
65 pcie: pcie@66000000 {85 pcie: pcie@66000000 {
66 compatible = "socionext,uniphier-pcie";86 compatible = "socionext,uniphier-pcie";
67 reg-names = "dbi", "link", "config";87 reg-names = "dbi", "link", "config";
@@ -80,6 +100,7 @@ examples: · 12 unmodified lines
80 phys = <&pcie_phy>;100 phys = <&pcie_phy>;
81 #interrupt-cells = <1>;101 #interrupt-cells = <1>;
82 interrupt-names = "dma", "msi";102 interrupt-names = "dma", "msi";
103 interrupt-parent = <&gic>;
83 interrupts = <0 224 4>, <0 225 4>;104 interrupts = <0 224 4>, <0 225 4>;
84 interrupt-map-mask = <0 0 0 7>;105 interrupt-map-mask = <0 0 0 7>;
85 interrupt-map = <0 0 0 1 &pcie_intc 0>,106 interrupt-map = <0 0 0 1 &pcie_intc 0>,
@@ -87,7 +108,7 @@ examples: · 1 unmodified line
87 <0 0 0 3 &pcie_intc 2>,108 <0 0 0 3 &pcie_intc 2>,
88 <0 0 0 4 &pcie_intc 3>;109 <0 0 0 4 &pcie_intc 3>;
89 110
90 pcie_intc: legacy-interrupt-controller {111 pcie_intc: interrupt-controller {
91 interrupt-controller;112 interrupt-controller;
92 #interrupt-cells = <1>;113 #interrupt-cells = <1>;
93 interrupt-parent = <&gic>;114 interrupt-parent = <&gic>;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t