Clang warns: drivers/misc/cardreader/rts5261.c:406:13: error: variable 'setting_reg2' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] } else if (efuse_valid == 0) { ^~~~~~~~~~~~~~~~ drivers/misc/cardreader/rts5261.c:412:30: note: uninitialized use occurs here pci_read_config_dword(pdev, setting_reg2, &lval2); ^~~~~~~~~~~~ efuse_valid == 1 is not a valid value so just return early from the function to avoid using setting_reg2 uninitialized.
Unified · Split
| @@ -407,6 +407,8 @@ static void rts5261_init_from_hw(struct rtsx_pcr *pcr) · 406 unmodified lines | ||
| 407 | 407 | // default |
| 408 | 408 | setting_reg1 = PCR_SETTING_REG1; |
| 409 | 409 | setting_reg2 = PCR_SETTING_REG2; |
| 410 | + } else { | |
| 411 | + return; | |
| 410 | 412 | } |
| 411 | 413 | |
| 412 | 414 | pci_read_config_dword(pdev, setting_reg2, &lval2); |