It needs to be anonymous memory (no file mappings) and we are requried to install an MMU notifier.
Unified · Split
| @@ -285,19 +285,24 @@ int radeon_gem_userptr_ioctl(struct drm_device *dev, void *data, · 284 unmodified lines | ||
| 285 | 285 | if (offset_in_page(args->addr | args->size)) |
| 286 | 286 | return -EINVAL; |
| 287 | 287 | |
| 288 | − /* we only support read only mappings for now */ | |
| 289 | − if (!(args->flags & RADEON_GEM_USERPTR_READONLY)) | |
| 290 | − return -EACCES; | |
| 291 | − | |
| 292 | 288 | /* reject unknown flag values */ |
| 293 | 289 | if (args->flags & ~(RADEON_GEM_USERPTR_READONLY | |
| 294 | 290 | RADEON_GEM_USERPTR_ANONONLY | RADEON_GEM_USERPTR_VALIDATE | |
| 295 | 291 | RADEON_GEM_USERPTR_REGISTER)) |
| 296 | 292 | return -EINVAL; |
| 297 | 293 | |
| 298 | − /* readonly pages not tested on older hardware */ | |
| 299 | − if (rdev->family < CHIP_R600) | |
| 300 | − return -EINVAL; | |
| 294 | + if (args->flags & RADEON_GEM_USERPTR_READONLY) { | |
| 295 | + /* readonly pages not tested on older hardware */ | |
| 296 | + if (rdev->family < CHIP_R600) | |
| 297 | + return -EINVAL; | |
| 298 | + | |
| 299 | + } else if (!(args->flags & RADEON_GEM_USERPTR_ANONONLY) || | |
| 300 | + !(args->flags & RADEON_GEM_USERPTR_REGISTER)) { | |
| 301 | + | |
| 302 | + /* if we want to write to it we must require anonymous | |
| 303 | + memory and install a MMU notifier */ | |
| 304 | + return -EACCES; | |
| 305 | + } | |
| 301 | 306 | |
| 302 | 307 | down_read(&rdev->exclusive_lock); |
| 303 | 308 | |