History

kallsyms: avoid repeated calculation of array size for markers

Introduce the markers_cnt variable for readability. No functional change intended.

Masahiro Yamada committed 2 years ago

Commit bde6fb31 parent c8578531 file · +4 −3Browse files

Unified · Split

scripts/kallsyms.c+4−3
@@ -393,7 +393,7 @@ static void write_src(void) · 392 unmodified lines
393{393{
394 unsigned int i, k, off;394 unsigned int i, k, off;
395 unsigned int best_idx[256];395 unsigned int best_idx[256];
396 unsigned int *markers;396 unsigned int *markers, markers_cnt;
397 char buf[KSYM_NAME_LEN];397 char buf[KSYM_NAME_LEN];
398 398
399 printf("#include <asm/bitsperlong.h>\n");399 printf("#include <asm/bitsperlong.h>\n");
@@ -413,7 +413,8 @@ static void write_src(void) · 13 unmodified lines
413 413
414 /* table of offset markers, that give the offset in the compressed stream414 /* table of offset markers, that give the offset in the compressed stream
415 * every 256 symbols */415 * every 256 symbols */
416 markers = malloc(sizeof(unsigned int) * ((table_cnt + 255) / 256));416 markers_cnt = (table_cnt + 255) / 256;
417 markers = malloc(sizeof(*markers) * markers_cnt);
417 if (!markers) {418 if (!markers) {
418 fprintf(stderr, "kallsyms failure: "419 fprintf(stderr, "kallsyms failure: "
419 "unable to allocate required memory\n");420 "unable to allocate required memory\n");
@@ -469,7 +470,7 @@ static void write_src(void) · 49 unmodified lines
469 }470 }
470 471
471 output_label("kallsyms_markers");472 output_label("kallsyms_markers");
472 for (i = 0; i < ((table_cnt + 255) >> 8); i++)473 for (i = 0; i < markers_cnt; i++)
473 printf("\t.long\t%u\n", markers[i]);474 printf("\t.long\t%u\n", markers[i]);
474 printf("\n");475 printf("\n");
475 476