History

y2038: Remove stat64 family from default syscall set

New architectures should no longer need stat64, which is not y2038 safe and has been replaced by statx(). This removes the 'select __ARCH_WANT_STAT64' statement from asm-generic/unistd.h and instead moves it into the respective asm/unistd.h UAPI header files for each architecture that uses it today. In the generic file, the system call number and entry points are now made conditional, so newly added architectures (e.g. riscv32 or csky) will never need to carry backwards compatiblity for it. arm64 is the only 64-bit architecture using the asm-generic/unistd.h file, and it already sets __ARCH_WANT_NEW_STAT in its headers, and I use the same #ifdef here: future 64-bit architectures therefore won't see newstat or stat64 any more. They don't suffer from the y2038 time_t overflow, but for consistency it seems best to also let them use statx().

Arnd Bergmann committed 8 years ago

Commit bf4b6a71 parent 82b355d10 files · +10 −1Browse files

Unified · Split

10 files
  1. arch/arc/include/uapi/asm/unistd.h +1 −0
  2. arch/c6x/include/uapi/asm/unistd.h +1 −0
  3. arch/h8300/include/uapi/asm/unistd.h +1 −0
  4. arch/hexagon/include/uapi/asm/unistd.h +1 −0
  5. arch/nds32/include/uapi/asm/unistd.h +1 −0
  6. arch/nios2/include/uapi/asm/unistd.h +1 −0
  7. arch/openrisc/include/uapi/asm/unistd.h +1 −0
  8. arch/unicore32/include/uapi/asm/unistd.h +1 −0
  9. include/asm-generic/unistd.h +0 −1
  10. include/uapi/asm-generic/unistd.h +2 −0
arch/arc/include/uapi/asm/unistd.h+1−0
@@ -17,6 +17,7 @@ · 16 unmodified lines
17#define _UAPI_ASM_ARC_UNISTD_H17#define _UAPI_ASM_ARC_UNISTD_H
18 18
19#define __ARCH_WANT_RENAMEAT19#define __ARCH_WANT_RENAMEAT
20#define __ARCH_WANT_STAT64
20#define __ARCH_WANT_SYS_EXECVE21#define __ARCH_WANT_SYS_EXECVE
21#define __ARCH_WANT_SYS_CLONE22#define __ARCH_WANT_SYS_CLONE
22#define __ARCH_WANT_SYS_VFORK23#define __ARCH_WANT_SYS_VFORK
arch/c6x/include/uapi/asm/unistd.h+1−0
@@ -16,6 +16,7 @@ · 15 unmodified lines
16 */16 */
17 17
18#define __ARCH_WANT_RENAMEAT18#define __ARCH_WANT_RENAMEAT
19#define __ARCH_WANT_STAT64
19#define __ARCH_WANT_SYS_CLONE20#define __ARCH_WANT_SYS_CLONE
20 21
21/* Use the standard ABI for syscalls. */22/* Use the standard ABI for syscalls. */
arch/h8300/include/uapi/asm/unistd.h+1−0
@@ -1,5 +1,6 @@
1#define __ARCH_NOMMU1#define __ARCH_NOMMU
2 2
3#define __ARCH_WANT_RENAMEAT3#define __ARCH_WANT_RENAMEAT
4#define __ARCH_WANT_STAT64
4 5
5#include <asm-generic/unistd.h>6#include <asm-generic/unistd.h>
arch/hexagon/include/uapi/asm/unistd.h+1−0
@@ -29,6 +29,7 @@ · 28 unmodified lines
29 29
30#define sys_mmap2 sys_mmap_pgoff30#define sys_mmap2 sys_mmap_pgoff
31#define __ARCH_WANT_RENAMEAT31#define __ARCH_WANT_RENAMEAT
32#define __ARCH_WANT_STAT64
32#define __ARCH_WANT_SYS_EXECVE33#define __ARCH_WANT_SYS_EXECVE
33#define __ARCH_WANT_SYS_CLONE34#define __ARCH_WANT_SYS_CLONE
34#define __ARCH_WANT_SYS_VFORK35#define __ARCH_WANT_SYS_VFORK
arch/nds32/include/uapi/asm/unistd.h+1−0
@@ -1,6 +1,7 @@
1// SPDX-License-Identifier: GPL-2.01// SPDX-License-Identifier: GPL-2.0
2// Copyright (C) 2005-2017 Andes Technology Corporation2// Copyright (C) 2005-2017 Andes Technology Corporation
3 3
4#define __ARCH_WANT_STAT64
4#define __ARCH_WANT_SYNC_FILE_RANGE25#define __ARCH_WANT_SYNC_FILE_RANGE2
5 6
6/* Use the standard ABI for syscalls */7/* Use the standard ABI for syscalls */
arch/nios2/include/uapi/asm/unistd.h+1−0
@@ -19,6 +19,7 @@ · 18 unmodified lines
19 #define sys_mmap2 sys_mmap_pgoff19 #define sys_mmap2 sys_mmap_pgoff
20 20
21#define __ARCH_WANT_RENAMEAT21#define __ARCH_WANT_RENAMEAT
22#define __ARCH_WANT_STAT64
22 23
23/* Use the standard ABI for syscalls */24/* Use the standard ABI for syscalls */
24#include <asm-generic/unistd.h>25#include <asm-generic/unistd.h>
arch/openrisc/include/uapi/asm/unistd.h+1−0
@@ -20,6 +20,7 @@ · 19 unmodified lines
20#define sys_mmap2 sys_mmap_pgoff20#define sys_mmap2 sys_mmap_pgoff
21 21
22#define __ARCH_WANT_RENAMEAT22#define __ARCH_WANT_RENAMEAT
23#define __ARCH_WANT_STAT64
23#define __ARCH_WANT_SYS_FORK24#define __ARCH_WANT_SYS_FORK
24#define __ARCH_WANT_SYS_CLONE25#define __ARCH_WANT_SYS_CLONE
25 26
arch/unicore32/include/uapi/asm/unistd.h+1−0
@@ -15,4 +15,5 @@ · 14 unmodified lines
15 15
16/* Use the standard ABI for syscalls. */16/* Use the standard ABI for syscalls. */
17#include <asm-generic/unistd.h>17#include <asm-generic/unistd.h>
18#define __ARCH_WANT_STAT64
18#define __ARCH_WANT_SYS_CLONE19#define __ARCH_WANT_SYS_CLONE
include/asm-generic/unistd.h+0−1
@@ -8,6 +8,5 @@ · 7 unmodified lines
8 * be selected by default.8 * be selected by default.
9 */9 */
10#if __BITS_PER_LONG == 3210#if __BITS_PER_LONG == 32
11#define __ARCH_WANT_STAT64
12#define __ARCH_WANT_SYS_LLSEEK11#define __ARCH_WANT_SYS_LLSEEK
13#endif12#endif
include/uapi/asm-generic/unistd.h+2−0
@@ -242,10 +242,12 @@ __SYSCALL(__NR_tee, sys_tee) · 241 unmodified lines
242/* fs/stat.c */242/* fs/stat.c */
243#define __NR_readlinkat 78243#define __NR_readlinkat 78
244__SYSCALL(__NR_readlinkat, sys_readlinkat)244__SYSCALL(__NR_readlinkat, sys_readlinkat)
245#if defined(__ARCH_WANT_NEW_STAT) || defined(__ARCH_WANT_STAT64)
245#define __NR3264_fstatat 79246#define __NR3264_fstatat 79
246__SC_3264(__NR3264_fstatat, sys_fstatat64, sys_newfstatat)247__SC_3264(__NR3264_fstatat, sys_fstatat64, sys_newfstatat)
247#define __NR3264_fstat 80248#define __NR3264_fstat 80
248__SC_3264(__NR3264_fstat, sys_fstat64, sys_newfstat)249__SC_3264(__NR3264_fstat, sys_fstat64, sys_newfstat)
250#endif
249 251
250/* fs/sync.c */252/* fs/sync.c */
251#define __NR_sync 81253#define __NR_sync 81

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t