History

Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang

A compilation -Wimplicit-fallthrough warning was enabled by commit a035d552a93b ("Makefile: Globally enable fall-through warning") Even though clang 10.0.0 does not currently support this warning without a patch, clang currently does not support a value for this option. Link: https://bugs.llvm.org/show_bug.cgi?id=39382 The gcc default for this warning is 3 so removing the =3 has no effect for gcc and enables the warning for patched versions of clang. Also remove the =3 from an existing use in a parisc Makefile: arch/parisc/math-emu/Makefile

Joe Perches committed 7 years ago

Commit bfd77141 parent 5aa91002 files · +2 −2Browse files

Unified · Split

2 files
  1. Makefile +1 −1
  2. arch/parisc/math-emu/Makefile +1 −1
Makefile+1−1
@@ -846,7 +846,7 @@ NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) -print-file-name=include) · 845 unmodified lines
846KBUILD_CFLAGS += -Wdeclaration-after-statement846KBUILD_CFLAGS += -Wdeclaration-after-statement
847 847
848# Warn about unmarked fall-throughs in switch statement.848# Warn about unmarked fall-throughs in switch statement.
849KBUILD_CFLAGS += $(call cc-option,-Wimplicit-fallthrough=3,)849KBUILD_CFLAGS += $(call cc-option,-Wimplicit-fallthrough,)
850 850
851# Variable Length Arrays (VLAs) should not be used anywhere in the kernel851# Variable Length Arrays (VLAs) should not be used anywhere in the kernel
852KBUILD_CFLAGS += -Wvla852KBUILD_CFLAGS += -Wvla
arch/parisc/math-emu/Makefile+1−1
@@ -18,4 +18,4 @@ obj-y := frnd.o driver.o decode_exc.o fpudispatch.o denormal.o \ · 17 unmodified lines
18# other very old or stripped-down PA-RISC CPUs -- not currently supported18# other very old or stripped-down PA-RISC CPUs -- not currently supported
19 19
20obj-$(CONFIG_MATH_EMULATION) += unimplemented-math-emulation.o20obj-$(CONFIG_MATH_EMULATION) += unimplemented-math-emulation.o
21CFLAGS_REMOVE_fpudispatch.o = -Wimplicit-fallthrough=321CFLAGS_REMOVE_fpudispatch.o = -Wimplicit-fallthrough