History

ipmi:ipmb: Fix unknown command response

More missed changes, the response back to another system sending a command that had no user to handle it wasn't formatted properly.

Corey Minyard committed 4 years ago

Commit c03a4871 parent d2c12f51 file · +5 −3Browse files

Unified · Split

drivers/char/ipmi/ipmi_msghandler.c+5−3
@@ -3920,9 +3920,11 @@ static int handle_ipmb_direct_rcv_cmd(struct ipmi_smi *intf, · 3919 unmodified lines
39203920 /* We didn't find a user, deliver an error response. */
39213921 ipmi_inc_stat(intf, unhandled_commands);
39223922
3923− msg->data[0] = ((netfn + 1) << 2) | (msg->rsp[4] & 0x3);
3924− msg->data[1] = msg->rsp[2];
3925− msg->data[2] = msg->rsp[4] & ~0x3;
3923+ msg->data[0] = (netfn + 1) << 2;
3924+ msg->data[0] |= msg->rsp[2] & 0x3; /* rqLUN */
3925+ msg->data[1] = msg->rsp[1]; /* Addr */
3926+ msg->data[2] = msg->rsp[2] & ~0x3; /* rqSeq */
3927+ msg->data[2] |= msg->rsp[0] & 0x3; /* rsLUN */
39263928 msg->data[3] = cmd;
39273929 msg->data[4] = IPMI_INVALID_CMD_COMPLETION_CODE;
39283930 msg->data_size = 5;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t