History

dmaengine: dw: rename masters to reflect actual topology

The source and destination masters are reflecting buses or their layers to where the different devices can be connected. The patch changes the master names to reflect which one is related to which independently on the transfer direction. The outcome of the change is that the memory data width is now always limited by a data width of the master which is dedicated to communicate to memory. The patch will not break anything since all current users have the same data width for all masters. Though it would be nice to revisit avr32 platforms to check what is the actual hardware topology in use there. It seems that it has one bus and two masters on it as stated by Table 8-2, that's why everything works independently on the master in use. The purpose of the sequential patch is to fix the driver for configuration of more than one bus. The change is done in the assumption that src_master and dst_master are reflecting a connection to the memory and peripheral correspondently on avr32 and otherwise on the rest.

Andy Shevchenko committed 10 years ago

Commit c4220251 parent 3fe64099 files · +41 −42Browse files

Showing the changes to include/linux/platform_data (1 of 9 files). Show all

Unified · Split

include/linux/platform_data/dma-dw.h+4−4
@@ -21,15 +21,15 @@ · 20 unmodified lines
2121 * @dma_dev: required DMA master device
2222 * @src_id: src request line
2323 * @dst_id: dst request line
24− * @src_master: src master for transfers on allocated channel.
25− * @dst_master: dest master for transfers on allocated channel.
24+ * @m_master: memory master for transfers on allocated channel
25+ * @p_master: peripheral master for transfers on allocated channel
2626 */
2727 struct dw_dma_slave {
2828 struct device *dma_dev;
2929 u8 src_id;
3030 u8 dst_id;
31− u8 src_master;
32− u8 dst_master;
31+ u8 m_master;
32+ u8 p_master;
3333 };
3434
3535 /**

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t