History

checkpatch: add a placeholder to check blank lines before declarations

Figure out first how to determine if this is in a struct declaration or in a function body before enabling this.

Joe Perches committed 13 years ago

Commit c4a62ef1 parent 3cc4b1c1 file · +8 −0Browse files

Showing the changes to scripts/checkpatch.pl (1 of 1 file). Show all

Unified · Split

scripts/checkpatch.pl+8−0
@@ -2750,6 +2750,14 @@ sub process { · 2749 unmodified lines
2750 "space required before the open brace '{'\n" . $herecurr);2750 "space required before the open brace '{'\n" . $herecurr);
2751 }2751 }
2752 2752
2753## # check for blank lines before declarations
2754## if ($line =~ /^.\t+$Type\s+$Ident(?:\s*=.*)?;/ &&
2755## $prevrawline =~ /^.\s*$/) {
2756## WARN("SPACING",
2757## "No blank lines before declarations\n" . $hereprev);
2758## }
2759##
2760
2753# closing brace should have a space following it when it has anything2761# closing brace should have a space following it when it has anything
2754# on the line2762# on the line
2755 if ($line =~ /}(?!(?:,|;|\)))\S/) {2763 if ($line =~ /}(?!(?:,|;|\)))\S/) {