History

checkpatch: add a placeholder to check blank lines before declarations

Figure out first how to determine if this is in a struct declaration or in a function body before enabling this.

Joe Perches committed 13 years ago

Commit c4a62ef1 parent 3cc4b1c1 file · +8 −0Browse files

Showing the changes to scripts/checkpatch.pl (1 of 1 file). Show all

Unified · Split

scripts/checkpatch.pl+8−0
@@ -2750,6 +2750,14 @@ sub process { · 2749 unmodified lines
27502750 "space required before the open brace '{'\n" . $herecurr);
27512751 }
27522752
2753+## # check for blank lines before declarations
2754+## if ($line =~ /^.\t+$Type\s+$Ident(?:\s*=.*)?;/ &&
2755+## $prevrawline =~ /^.\s*$/) {
2756+## WARN("SPACING",
2757+## "No blank lines before declarations\n" . $hereprev);
2758+## }
2759+##
2760+
27532761 # closing brace should have a space following it when it has anything
27542762 # on the line
27552763 if ($line =~ /}(?!(?:,|;|\)))\S/) {