The concurrent positioning ranges log is not a fixed size and may depend on how many ranges are supported by the device. This patch uses the size reported in the GPL directory to determine the number of pages supported by the device before attempting to read this log page. This resolves this error from the dmesg output: ata6.00: Read log 0x47 page 0x00 failed, Emask 0x1
Unified · Split
| @@ -2010,16 +2010,16 @@ retry: · 2009 unmodified lines | ||
| 2010 | 2010 | return err_mask; |
| 2011 | 2011 | } |
| 2012 | 2012 | |
| 2013 | −static bool ata_log_supported(struct ata_device *dev, u8 log) | |
| 2013 | +static int ata_log_supported(struct ata_device *dev, u8 log) | |
| 2014 | 2014 | { |
| 2015 | 2015 | struct ata_port *ap = dev->link->ap; |
| 2016 | 2016 | |
| 2017 | 2017 | if (dev->horkage & ATA_HORKAGE_NO_LOG_DIR) |
| 2018 | − return false; | |
| 2018 | + return 0; | |
| 2019 | 2019 | |
| 2020 | 2020 | if (ata_read_log_page(dev, ATA_LOG_DIRECTORY, 0, ap->sector_buf, 1)) |
| 2021 | − return false; | |
| 2022 | − return get_unaligned_le16(&ap->sector_buf[log * 2]) ? true : false; | |
| 2021 | + return 0; | |
| 2022 | + return get_unaligned_le16(&ap->sector_buf[log * 2]); | |
| 2023 | 2023 | } |
| 2024 | 2024 | |
| 2025 | 2025 | static bool ata_identify_page_supported(struct ata_device *dev, u8 page) |
| @@ -2455,15 +2455,20 @@ static void ata_dev_config_cpr(struct ata_device *dev) · 429 unmodified lines | ||
| 2455 | 2455 | struct ata_cpr_log *cpr_log = NULL; |
| 2456 | 2456 | u8 *desc, *buf = NULL; |
| 2457 | 2457 | |
| 2458 | − if (ata_id_major_version(dev->id) < 11 || | |
| 2459 | − !ata_log_supported(dev, ATA_LOG_CONCURRENT_POSITIONING_RANGES)) | |
| 2458 | + if (ata_id_major_version(dev->id) < 11) | |
| 2459 | + goto out; | |
| 2460 | + | |
| 2461 | + buf_len = ata_log_supported(dev, ATA_LOG_CONCURRENT_POSITIONING_RANGES); | |
| 2462 | + if (buf_len == 0) | |
| 2460 | 2463 | goto out; |
| 2461 | 2464 | |
| 2462 | 2465 | /* |
| 2463 | 2466 | * Read the concurrent positioning ranges log (0x47). We can have at |
| 2464 | − * most 255 32B range descriptors plus a 64B header. | |
| 2467 | + * most 255 32B range descriptors plus a 64B header. This log varies in | |
| 2468 | + * size, so use the size reported in the GPL directory. Reading beyond | |
| 2469 | + * the supported length will result in an error. | |
| 2465 | 2470 | */ |
| 2466 | − buf_len = (64 + 255 * 32 + 511) & ~511; | |
| 2471 | + buf_len <<= 9; | |
| 2467 | 2472 | buf = kzalloc(buf_len, GFP_KERNEL); |
| 2468 | 2473 | if (!buf) |
| 2469 | 2474 | goto out; |