History

net: rework SIOCGSTAMP ioctl handling

The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many socket protocol handlers, and all of those end up calling the same sock_get_timestamp()/sock_get_timestampns() helper functions, which results in a lot of duplicate code. With the introduction of 64-bit time_t on 32-bit architectures, this gets worse, as we then need four different ioctl commands in each socket protocol implementation. To simplify that, let's add a new .gettstamp() operation in struct proto_ops, and move ioctl implementation into the common sock_ioctl()/compat_sock_ioctl_trans() functions that these all go through. We can reuse the sock_get_timestamp() implementation, but generalize it so it can deal with both native and compat mode, as well as timeval and timespec structures.

Arnd Bergmann committed 7 years ago

Commit c7cbdbf1 parent 1ab839233 files · +75 −232Browse files

Showing the changes to include/linux (1 of 33 files). Show all

Unified · Split

include/linux/net.h+2−0
@@ -161,6 +161,8 @@ struct proto_ops { · 160 unmodified lines
161 int (*compat_ioctl) (struct socket *sock, unsigned int cmd,161 int (*compat_ioctl) (struct socket *sock, unsigned int cmd,
162 unsigned long arg);162 unsigned long arg);
163#endif163#endif
164 int (*gettstamp) (struct socket *sock, void __user *userstamp,
165 bool timeval, bool time32);
164 int (*listen) (struct socket *sock, int len);166 int (*listen) (struct socket *sock, int len);
165 int (*shutdown) (struct socket *sock, int flags);167 int (*shutdown) (struct socket *sock, int flags);
166 int (*setsockopt)(struct socket *sock, int level,168 int (*setsockopt)(struct socket *sock, int level,

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t