commit 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx") added a function irq_dispatch, and it'll increase irq_err_count when the get_irq callback returns a negative value, but increase irq_err_count in get_irq was not removed. And also, modpost complains once gpio-vr41xx drivers become modules. ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined! So it would be a good idea to remove repetitive increase irq_err_count in get_irq callback.
Unified · Split
| @@ -640,8 +640,6 @@ static int icu_get_irq(unsigned int irq) · 639 unmodified lines | ||
| 640 | 640 | |
| 641 | 641 | printk(KERN_ERR "spurious ICU interrupt: %04x,%04x\n", pend1, pend2); |
| 642 | 642 | |
| 643 | − atomic_inc(&irq_err_count); | |
| 644 | − | |
| 645 | 643 | return -1; |
| 646 | 644 | } |
| 647 | 645 | |
| @@ -217,8 +217,6 @@ static int giu_get_irq(unsigned int irq) · 216 unmodified lines | ||
| 217 | 217 | printk(KERN_ERR "spurious GIU interrupt: %04x(%04x),%04x(%04x)\n", |
| 218 | 218 | maskl, pendl, maskh, pendh); |
| 219 | 219 | |
| 220 | − atomic_inc(&irq_err_count); | |
| 221 | − | |
| 222 | 220 | return -EINVAL; |
| 223 | 221 | } |
| 224 | 222 | |