History

perf: Fix strncpy() use, always make sure it's NUL terminated

For NUL terminated string, always make sure that there's '\0' at the end. In our case we need a return value, so still use strncpy() and fix up the tail explicitly. (strlcpy() returns the size, not the pointer)

Chen Gang committed 13 years ago

Commit c97847d1 parent dd9c0861 file · +2 −1Browse files

Showing the changes to kernel (1 of 1 file). Show all

Unified · Split

kernel/events/core.c+2−1
@@ -4737,7 +4737,8 @@ static void perf_event_mmap_event(struct perf_mmap_event *mmap_event) · 4736 unmodified lines
47374737 } else {
47384738 if (arch_vma_name(mmap_event->vma)) {
47394739 name = strncpy(tmp, arch_vma_name(mmap_event->vma),
4740− sizeof(tmp));
4740+ sizeof(tmp) - 1);
4741+ tmp[sizeof(tmp) - 1] = '\0';
47414742 goto got_name;
47424743 }
47434744

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t