Commit 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be ordered") enabled implicit ordered attribute to be added to WQ_UNBOUND workqueues with max_active of 1. This prevented the changing of attributes to these workqueues leading to fix commit 0a94efb5acbb ("workqueue: implicit ordered attribute should be overridable"). However, workqueue_apply_unbound_cpumask() was not updated at that time. So sysfs changes to wq_unbound_cpumask has no effect on WQ_UNBOUND workqueues with implicit ordered attribute. Since not all WQ_UNBOUND workqueues are visible on sysfs, we are not able to make all the necessary cpumask changes even if we iterates all the workqueue cpumasks in sysfs and changing them one by one. Fix this problem by applying the corresponding change made to apply_workqueue_attrs_locked() in the fix commit to workqueue_apply_unbound_cpumask().
Unified · Split
| @@ -5792,9 +5792,13 @@ static int workqueue_apply_unbound_cpumask(const cpumask_var_t unbound_cpumask) · 5791 unmodified lines | ||
| 5792 | 5792 | list_for_each_entry(wq, &workqueues, list) { |
| 5793 | 5793 | if (!(wq->flags & WQ_UNBOUND)) |
| 5794 | 5794 | continue; |
| 5795 | + | |
| 5795 | 5796 | /* creating multiple pwqs breaks ordering guarantee */ |
| 5796 | − if (wq->flags & __WQ_ORDERED) | |
| 5797 | − continue; | |
| 5797 | + if (!list_empty(&wq->pwqs)) { | |
| 5798 | + if (wq->flags & __WQ_ORDERED_EXPLICIT) | |
| 5799 | + continue; | |
| 5800 | + wq->flags &= ~__WQ_ORDERED; | |
| 5801 | + } | |
| 5798 | 5802 | |
| 5799 | 5803 | ctx = apply_wqattrs_prepare(wq, wq->unbound_attrs, unbound_cpumask); |
| 5800 | 5804 | if (IS_ERR(ctx)) { |