History

Merge tag 'batadv-next-for-davem-20180302' of git://git.open-mesh.org/linux-merge

Simon Wunderlich says: ==================== This cleanup patchset includes the following patches: - bump version strings, by Simon Wunderlich - bump copyright years, by Sven Eckelmann - fix macro indendation for checkpatch, by Sven Eckelmann - fix comparison operator for bool returning functions, by Sven Eckelmann - assume 2-byte packet alignments for all packet types, by Matthias Schiffer ====================

David S. Miller committed 8 years ago

Commit ca435f82 parents 3518e40 a163dc261 files · +72 −79Browse files

Showing the changes to include/uapi/linux (2 of 61 files). Show all

Unified · Split

2 files
  1. include/uapi/linux/batadv_packet.h +3 −12
  2. include/uapi/linux/batman_adv.h +1 −1
include/uapi/linux/batadv_packet.h+3−12
@@ -1,5 +1,5 @@
11 /* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) */
2−/* Copyright (C) 2007-2017 B.A.T.M.A.N. contributors:
2+/* Copyright (C) 2007-2018 B.A.T.M.A.N. contributors:
33 *
44 * Marek Lindner, Simon Wunderlich
55 *
@@ -196,8 +196,6 @@ struct batadv_bla_claim_dst { · 190 unmodified lines
196196 __be16 group; /* group id */
197197 };
198198
199−#pragma pack()
200−
201199 /**
202200 * struct batadv_ogm_packet - ogm (routing protocol) packet
203201 * @packet_type: batman-adv packet type, part of the general header
@@ -222,9 +220,6 @@ struct batadv_ogm_packet { · 18 unmodified lines
222220 __u8 reserved;
223221 __u8 tq;
224222 __be16 tvlv_len;
225− /* __packed is not needed as the struct size is divisible by 4,
226− * and the largest data type in this struct has a size of 4.
227− */
228223 };
229224
230225 #define BATADV_OGM_HLEN sizeof(struct batadv_ogm_packet)
@@ -249,9 +244,6 @@ struct batadv_ogm2_packet { · 18 unmodified lines
249244 __u8 orig[ETH_ALEN];
250245 __be16 tvlv_len;
251246 __be32 throughput;
252− /* __packed is not needed as the struct size is divisible by 4,
253− * and the largest data type in this struct has a size of 4.
254− */
255247 };
256248
257249 #define BATADV_OGM2_HLEN sizeof(struct batadv_ogm2_packet)
@@ -405,7 +397,6 @@ struct batadv_icmp_packet_rr { · 147 unmodified lines
405397 * misalignment of the payload after the ethernet header. It may also lead to
406398 * leakage of information when the padding it not initialized before sending.
407399 */
408−#pragma pack(2)
409400
410401 /**
411402 * struct batadv_unicast_packet - unicast packet for network payload
@@ -533,8 +524,6 @@ struct batadv_coded_packet { · 121 unmodified lines
533524 __be16 coded_len;
534525 };
535526
536−#pragma pack()
537−
538527 /**
539528 * struct batadv_unicast_tvlv_packet - generic unicast packet with tvlv payload
540529 * @packet_type: batman-adv packet type, part of the general header
@@ -641,4 +630,6 @@ struct batadv_tvlv_mcast_data { · 100 unmodified lines
641630 __u8 reserved[3];
642631 };
643632
633+#pragma pack()
634+
644635 #endif /* _UAPI_LINUX_BATADV_PACKET_H_ */
include/uapi/linux/batman_adv.h+1−1
@@ -1,5 +1,5 @@
11 /* SPDX-License-Identifier: MIT */
2−/* Copyright (C) 2016-2017 B.A.T.M.A.N. contributors:
2+/* Copyright (C) 2016-2018 B.A.T.M.A.N. contributors:
33 *
44 * Matthias Schiffer
55 *

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t