History

stmmac: fix parameter to dwmac4_set_umac_addr()

The dwmac4_set_umac_addr() takes a struct mac_device_info as the first parameter, but is being passed a ioaddr instead from dwmac4_set_filter(). Fix the warning/bug by changing the first parameter. drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:159:46: warning: incorrect type in argument 1 (different address spaces) drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:159:46: expected struct mac_device_info *hw drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:159:46: got void [noderef] <asn:2>*ioaddr Note, only compile tested this as do not have any hardware with it in.

Ben Dooks committed 10 years ago

Commit ca8bdaf1 parent 8618e6e1 file · +1 −1Browse files

Unified · Split

drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c+1−1
@@ -156,7 +156,7 @@ static void dwmac4_set_filter(struct mac_device_info *hw, · 155 unmodified lines
156156 struct netdev_hw_addr *ha;
157157
158158 netdev_for_each_uc_addr(ha, dev) {
159− dwmac4_set_umac_addr(ioaddr, ha->addr, reg);
159+ dwmac4_set_umac_addr(hw, ha->addr, reg);
160160 reg++;
161161 }
162162 }