History

export_report: use warn() to issue WARNING, so they go to stderr

Also count CONFIG_MODVERSIONS warnings, and print a NOTE at start of SECTION 2 if any were issued. Section 2 will be empty if the build is lacking this CONFIG_ item, and user may have missed the warnings, as they're off screen.

Jim Cromie committed 15 years ago

Commit ca995cb1 parent bdabc7a1 file · +7 −1Browse files

Showing the changes to scripts (1 of 1 file). Show all

Unified · Split

scripts/export_report.pl+7−1
@@ -102,6 +102,8 @@ close($module_symvers); · 101 unmodified lines
102102 #
103103 # collect the usage count of each symbol.
104104 #
105+my $modversion_warnings = 0;
106+
105107 foreach my $thismod (@allcfiles) {
106108 my $module;
107109
@@ -132,7 +134,8 @@ foreach my $thismod (@allcfiles) { · 24 unmodified lines
132134 }
133135 }
134136 if ($state != 2) {
135− print "WARNING:$thismod is not built with CONFIG_MODVERSION enabled\n";
137+ warn "WARNING:$thismod is not built with CONFIG_MODVERSIONS enabled\n";
138+ $modversion_warnings++;
136139 }
137140 close($module);
138141 }
@@ -166,6 +169,9 @@ printf("SECTION 2:\n\tThis section reports export-symbol-usage of in-kernel · 27 unmodified lines
166169 modules. Each module lists the modules, and the symbols from that module that
167170 it uses. Each listed symbol reports the number of modules using it\n");
168171
172+print "\nNOTE: Got $modversion_warnings CONFIG_MODVERSIONS warnings\n\n"
173+ if $modversion_warnings;
174+
169175 print "~"x80 , "\n";
170176 for my $thismod (sort keys %MODULE) {
171177 my $list = $MODULE{$thismod};

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t