We currently get all kinds of errors building the omap gpio driver as a module starting with: undefined reference to `omap2_gpio_resume_after_idle' undefined reference to `omap2_gpio_prepare_for_idle' ... Let's fix the issue by adding inline functions to the header. Note that we can now also remove the two unused functions for omap_set_gpio_debounce and omap_set_gpio_debounce_time. Then doing rmmod on the module produces further warnings because of missing exit related functions. Let's add those. And finally, we can make the Kconfig entry just a tristate option that's selected for omaps.
Showing the changes to include/linux/platform_data (1 of 3 files). Show all
Unified · Split
| @@ -208,9 +208,17 @@ struct omap_gpio_platform_data { · 207 unmodified lines | ||
| 208 | 208 | int (*get_context_loss_count)(struct device *dev); |
| 209 | 209 | }; |
| 210 | 210 | |
| 211 | +#if IS_BUILTIN(CONFIG_GPIO_OMAP) | |
| 211 | 212 | extern void omap2_gpio_prepare_for_idle(int off_mode); |
| 212 | 213 | extern void omap2_gpio_resume_after_idle(void); |
| 213 | −extern void omap_set_gpio_debounce(int gpio, int enable); | |
| 214 | −extern void omap_set_gpio_debounce_time(int gpio, int enable); | |
| 214 | +#else | |
| 215 | +static inline void omap2_gpio_prepare_for_idle(int off_mode) | |
| 216 | +{ | |
| 217 | +} | |
| 218 | + | |
| 219 | +static inline void omap2_gpio_resume_after_idle(void) | |
| 220 | +{ | |
| 221 | +} | |
| 222 | +#endif | |
| 215 | 223 | |
| 216 | 224 | #endif |