History

cxl: Use fixed width predefined types in data structure.

This patch fixes a regression introduced by commit b810253bd934 ("cxl: Add mechanism for delivering AFU driver specific events"). It changes the type u8 to __u8 in the uapi header cxl.h, because the former is a kernel internal type, and may not be defined in userland build environments, in particular when cross-compiling libcxl on x86_64 linux machines (RHEL6.7 and Ubuntu 16.04). This patch also changes the size of the field data_size, and makes it constant, to support 32-bit userland applications running on big-endian ppc64 kernels transparently. mpe: This is an ABI change, however the ABI was only added during the 4.8 merge window so has never been part of a released kernel - therefore we give ourselves permission to change it.

Philippe Bergheaud committed 10 years ago

Commit cbd74e11 parent 546c4401 file · +2 −2Browse files

Showing the changes to include/uapi (1 of 1 file). Show all

Unified · Split

include/uapi/misc/cxl.h+2−2
@@ -136,8 +136,8 @@ struct cxl_event_afu_driver_reserved { · 135 unmodified lines
136 *136 *
137 * Of course the contents will be ABI, but that's up the AFU driver.137 * Of course the contents will be ABI, but that's up the AFU driver.
138 */138 */
139 size_t data_size;139 __u32 data_size;
140 u8 data[];140 __u8 data[];
141};141};
142 142
143struct cxl_event {143struct cxl_event {