History

signals, pkeys: Notify userspace about protection key faults

A protection key fault is very similar to any other access error. There must be a VMA, etc... We even want to take the same action (SIGSEGV) that we do with a normal access fault. However, we do need to let userspace know that something is different. We do this the same way what we did with SEGV_BNDERR with Memory Protection eXtensions (MPX): define a new SEGV code: SEGV_PKUERR. We add a siginfo field: si_pkey that reveals to userspace which protection key was set on the PTE that we faulted on. There is no other easy way for userspace to figure this out. They could parse smaps but that would be a bit cruel. We share space with in siginfo with _addr_bnd. #BR faults from MPX are completely separate from page faults (#PF) that trigger from protection key violations, so we never need both at the same time. Note that _pkey is a 64-bit value. The current hardware only supports 4-bit protection keys. We do this because there is _plenty_ of space in _sigfault and it is possible that future processors would support more than 4 bits of protection keys. The x86 code to actually fill in the siginfo is in the next patch.

Dave Hansen committed 10 years ago

Commit cd0ea351 parent b376cd02 files · +16 −5Browse files

Showing the changes to include/uapi (1 of 2 files). Show all

Unified · Split

include/uapi/asm-generic/siginfo.h+12−5
@@ -91,10 +91,15 @@ typedef struct siginfo { · 90 unmodified lines
91 int _trapno; /* TRAP # which caused the signal */91 int _trapno; /* TRAP # which caused the signal */
92#endif92#endif
93 short _addr_lsb; /* LSB of the reported address */93 short _addr_lsb; /* LSB of the reported address */
94 struct {94 union {
95 void __user *_lower;95 /* used when si_code=SEGV_BNDERR */
96 void __user *_upper;96 struct {
97 } _addr_bnd;97 void __user *_lower;
98 void __user *_upper;
99 } _addr_bnd;
100 /* used when si_code=SEGV_PKUERR */
101 u64 _pkey;
102 };
98 } _sigfault;103 } _sigfault;
99 104
100 /* SIGPOLL */105 /* SIGPOLL */
@@ -137,6 +142,7 @@ typedef struct siginfo { · 36 unmodified lines
137#define si_addr_lsb _sifields._sigfault._addr_lsb142#define si_addr_lsb _sifields._sigfault._addr_lsb
138#define si_lower _sifields._sigfault._addr_bnd._lower143#define si_lower _sifields._sigfault._addr_bnd._lower
139#define si_upper _sifields._sigfault._addr_bnd._upper144#define si_upper _sifields._sigfault._addr_bnd._upper
145#define si_pkey _sifields._sigfault._pkey
140#define si_band _sifields._sigpoll._band146#define si_band _sifields._sigpoll._band
141#define si_fd _sifields._sigpoll._fd147#define si_fd _sifields._sigpoll._fd
142#ifdef __ARCH_SIGSYS148#ifdef __ARCH_SIGSYS
@@ -206,7 +212,8 @@ typedef struct siginfo { · 63 unmodified lines
206#define SEGV_MAPERR (__SI_FAULT|1) /* address not mapped to object */212#define SEGV_MAPERR (__SI_FAULT|1) /* address not mapped to object */
207#define SEGV_ACCERR (__SI_FAULT|2) /* invalid permissions for mapped object */213#define SEGV_ACCERR (__SI_FAULT|2) /* invalid permissions for mapped object */
208#define SEGV_BNDERR (__SI_FAULT|3) /* failed address bound checks */214#define SEGV_BNDERR (__SI_FAULT|3) /* failed address bound checks */
209#define NSIGSEGV 3215#define SEGV_PKUERR (__SI_FAULT|4) /* failed protection key checks */
216#define NSIGSEGV 4
210 217
211/*218/*
212 * SIGBUS si_codes219 * SIGBUS si_codes

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t