History

afs: Fix possible assert with callbacks from yfs servers

Servers sending callback breaks to the YFS_CM_SERVICE service may send up to YFSCBMAX (1024) fids in a single RPC. Anything over AFSCBMAX (50) will cause the assert in afs_break_callbacks to trigger. Remove the assert, as the count has already been checked against the appropriate max values in afs_deliver_cb_callback and afs_deliver_yfs_cb_callback.

Marc Dionne committed 6 years ago

Commit cd340701 parent cc079031 file · +0 −1Browse files

Unified · Split

fs/afs/callback.c+0−1
@@ -312,7 +312,6 @@ void afs_break_callbacks(struct afs_server *server, size_t count, · 311 unmodified lines
312 _enter("%p,%zu,", server, count);312 _enter("%p,%zu,", server, count);
313 313
314 ASSERT(server != NULL);314 ASSERT(server != NULL);
315 ASSERTCMP(count, <=, AFSCBMAX);
316 315
317 /* TODO: Sort the callback break list by volume ID */316 /* TODO: Sort the callback break list by volume ID */
318 317