History

numa: make "nr_online_nodes" unsigned int

Number of online NUMA nodes can't be negative as well. This doesn't save space as the variable is used only in 32-bit context, but do it anyway for consistency.

Alexey Dobriyan committed 7 years ago

Commit ce0725f1 parent b9726c22 files · +4 −4Browse files

Unified · Split

2 files
  1. include/linux/nodemask.h +2 −2
  2. mm/page_alloc.c +2 −2
include/linux/nodemask.h+2−2
@@ -445,7 +445,7 @@ static inline int next_memory_node(int nid) · 444 unmodified lines
445}445}
446 446
447extern unsigned int nr_node_ids;447extern unsigned int nr_node_ids;
448extern int nr_online_nodes;448extern unsigned int nr_online_nodes;
449 449
450static inline void node_set_online(int nid)450static inline void node_set_online(int nid)
451{451{
@@ -486,7 +486,7 @@ static inline int num_node_state(enum node_states state) · 34 unmodified lines
486#define first_memory_node 0486#define first_memory_node 0
487#define next_online_node(nid) (MAX_NUMNODES)487#define next_online_node(nid) (MAX_NUMNODES)
488#define nr_node_ids 1U488#define nr_node_ids 1U
489#define nr_online_nodes 1489#define nr_online_nodes 1U
490 490
491#define node_set_online(node) node_set_state((node), N_ONLINE)491#define node_set_online(node) node_set_state((node), N_ONLINE)
492#define node_set_offline(node) node_clear_state((node), N_ONLINE)492#define node_set_offline(node) node_clear_state((node), N_ONLINE)
mm/page_alloc.c+2−2
@@ -290,7 +290,7 @@ EXPORT_SYMBOL(movable_zone); · 289 unmodified lines
290 290
291#if MAX_NUMNODES > 1291#if MAX_NUMNODES > 1
292unsigned int nr_node_ids __read_mostly = MAX_NUMNODES;292unsigned int nr_node_ids __read_mostly = MAX_NUMNODES;
293int nr_online_nodes __read_mostly = 1;293unsigned int nr_online_nodes __read_mostly = 1;
294EXPORT_SYMBOL(nr_node_ids);294EXPORT_SYMBOL(nr_node_ids);
295EXPORT_SYMBOL(nr_online_nodes);295EXPORT_SYMBOL(nr_online_nodes);
296#endif296#endif
@@ -5664,7 +5664,7 @@ void __ref build_all_zonelists(pg_data_t *pgdat) · 5367 unmodified lines
5664 else5664 else
5665 page_group_by_mobility_disabled = 0;5665 page_group_by_mobility_disabled = 0;
5666 5666
5667 pr_info("Built %i zonelists, mobility grouping %s. Total pages: %ld\n",5667 pr_info("Built %u zonelists, mobility grouping %s. Total pages: %ld\n",
5668 nr_online_nodes,5668 nr_online_nodes,
5669 page_group_by_mobility_disabled ? "off" : "on",5669 page_group_by_mobility_disabled ? "off" : "on",
5670 vm_total_pages);5670 vm_total_pages);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t