History

drm/msm: Fix double pm_runtime_disable() call

Following commit 17e822f7591f ("drm/msm: fix unbalanced pm_runtime_enable in adreno_gpu_{init, cleanup}"), any call to adreno_unbind() will disable runtime PM twice, as indicated by the call trees below: adreno_unbind() -> pm_runtime_force_suspend() -> pm_runtime_disable() adreno_unbind() -> gpu->funcs->destroy() [= aNxx_destroy()] -> adreno_gpu_cleanup() -> pm_runtime_disable() Note that pm_runtime_force_suspend() is called right before gpu->funcs->destroy() and both functions are called unconditionally. With recent addition of the eDP AUX bus code, this problem manifests itself when the eDP panel cannot be found yet and probing is deferred. On the first probe attempt, we disable runtime PM twice as described above. This then causes any later probe attempt to fail with [drm:adreno_load_gpu [msm]] *ERROR* Couldn't power up the GPU: -13 preventing the driver from loading. As there seem to be scenarios where the aNxx_destroy() functions are not called from adreno_unbind(), simply removing pm_runtime_disable() from inside adreno_unbind() does not seem to be the proper fix. This is what commit 17e822f7591f ("drm/msm: fix unbalanced pm_runtime_enable in adreno_gpu_{init, cleanup}") intended to fix. Therefore, instead check whether runtime PM is still enabled, and only disable it in that case.

Maximilian Luz committed 4 years ago

Commit ce0db501 parent 036d2071 file · +2 −1Browse files

Unified · Split

drivers/gpu/drm/msm/adreno/adreno_gpu.c+2−1
@@ -1057,7 +1057,8 @@ void adreno_gpu_cleanup(struct adreno_gpu *adreno_gpu) · 1056 unmodified lines
1057 for (i = 0; i < ARRAY_SIZE(adreno_gpu->info->fw); i++)1057 for (i = 0; i < ARRAY_SIZE(adreno_gpu->info->fw); i++)
1058 release_firmware(adreno_gpu->fw[i]);1058 release_firmware(adreno_gpu->fw[i]);
1059 1059
1060 pm_runtime_disable(&priv->gpu_pdev->dev);1060 if (pm_runtime_enabled(&priv->gpu_pdev->dev))
1061 pm_runtime_disable(&priv->gpu_pdev->dev);
1061 1062
1062 msm_gpu_cleanup(&adreno_gpu->base);1063 msm_gpu_cleanup(&adreno_gpu->base);
1063}1064}

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t