History

Revert "net: snmp: add statistics for tcp small queue check"

This reverts commit aeeecb889165617a841e939117f9a8095d0e7d80. The new SNMP variable (TCPSmallQueueFailure) can be incremented for good reasons, even on a 100Gbit single TCP_STREAM flow. If we really wanted to ease driver debugging [1], this would require something more sophisticated. [1] Usually, if a driver is delaying TX completions too much, this can lead to stalls in TCP output. Various work arounds have been used in the past, like skb_orphan() in ndo_start_xmit().

Eric Dumazet committed 4 years ago

Commit ce8299b1 parent 0dc1df03 files · +1 −6Browse files

Showing the changes to include/uapi (1 of 3 files). Show all

Unified · Split

include/uapi/linux/snmp.h+0−1
@@ -292,7 +292,6 @@ enum · 291 unmodified lines
292292 LINUX_MIB_TCPDSACKIGNOREDDUBIOUS, /* TCPDSACKIgnoredDubious */
293293 LINUX_MIB_TCPMIGRATEREQSUCCESS, /* TCPMigrateReqSuccess */
294294 LINUX_MIB_TCPMIGRATEREQFAILURE, /* TCPMigrateReqFailure */
295− LINUX_MIB_TCPSMALLQUEUEFAILURE, /* TCPSmallQueueFailure */
296295 __LINUX_MIB_MAX
297296 };
298297