History

sched/core: Convert sighand_struct.count to refcount_t

atomic_t variables are currently used to implement reference counters with the following properties: - counter is initialized to 1 using atomic_set() - a resource is freed upon counter reaching zero - once counter reaches zero, its further increments aren't allowed - counter schema uses basic atomic operations (set, inc, inc_not_zero, dec_and_test, etc.) Such atomic variables should be converted to a newly provided refcount_t type and API that prevents accidental counter overflows and underflows. This is important since overflows and underflows can lead to use-after-free situation and be exploitable. The variable sighand_struct.count is used as pure reference counter. Convert it to refcount_t and fix up the operations. ** Important note for maintainers: Some functions from refcount_t API defined in lib/refcount.c have different memory ordering guarantees than their atomic counterparts. The full comparison can be seen in https://lkml.org/lkml/2017/11/15/57 and it is hopefully soon in state to be merged to the documentation tree. Normally the differences should not matter since refcount_t provides enough guarantees to satisfy the refcounting use cases, but in some rare cases it might matter. Please double check that you don't have some undocumented memory guarantees for this variable usage. For the sighand_struct.count it might make a difference in following places: - __cleanup_sighand: decrement in refcount_dec_and_test() only provides RELEASE ordering and control dependency on success vs. fully ordered atomic counterpart

Elena Reshetova committed 7 years ago

Commit d036bda1 parent 15917dc4 files · +9 −8Browse files

Showing the changes to include/linux (1 of 4 files). Show all

Unified · Split

include/linux/sched/signal.h+2−1
@@ -8,13 +8,14 @@ · 7 unmodified lines
8#include <linux/sched/jobctl.h>8#include <linux/sched/jobctl.h>
9#include <linux/sched/task.h>9#include <linux/sched/task.h>
10#include <linux/cred.h>10#include <linux/cred.h>
11#include <linux/refcount.h>
11 12
12/*13/*
13 * Types defining task->signal and task->sighand and APIs using them:14 * Types defining task->signal and task->sighand and APIs using them:
14 */15 */
15 16
16struct sighand_struct {17struct sighand_struct {
17 atomic_t count;18 refcount_t count;
18 struct k_sigaction action[_NSIG];19 struct k_sigaction action[_NSIG];
19 spinlock_t siglock;20 spinlock_t siglock;
20 wait_queue_head_t signalfd_wqh;21 wait_queue_head_t signalfd_wqh;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t