History

dev_addr: add a modification check

netdev->dev_addr should only be modified via helpers, but someone may be casting off the const. Add a runtime check to catch abuses.

Jakub Kicinski committed 4 years ago

Commit d07b26f1 parent 5f0b6923 files · +25 −0Browse files

Showing the changes to include (1 of 3 files). Show all

Unified · Split

include/linux/netdevice.h+5−0
@@ -1942,6 +1942,8 @@ enum netdev_ml_priv_type { · 1941 unmodified lines
1942 * @unlink_list: As netif_addr_lock() can be called recursively,1942 * @unlink_list: As netif_addr_lock() can be called recursively,
1943 * keep a list of interfaces to be deleted.1943 * keep a list of interfaces to be deleted.
1944 *1944 *
1945 * @dev_addr_shadow: Copy of @dev_addr to catch direct writes.
1946 *
1945 * FIXME: cleanup struct net_device such that network protocol info1947 * FIXME: cleanup struct net_device such that network protocol info
1946 * moves out.1948 * moves out.
1947 */1949 */
@@ -2268,6 +2270,8 @@ struct net_device { · 320 unmodified lines
2268 2270
2269 /* protected by rtnl_lock */2271 /* protected by rtnl_lock */
2270 struct bpf_xdp_entity xdp_state[__MAX_XDP_MODE];2272 struct bpf_xdp_entity xdp_state[__MAX_XDP_MODE];
2273
2274 u8 dev_addr_shadow[MAX_ADDR_LEN];
2271};2275};
2272#define to_net_dev(d) container_of(d, struct net_device, dev)2276#define to_net_dev(d) container_of(d, struct net_device, dev)
2273 2277
@@ -4288,6 +4292,7 @@ int dev_addr_del(struct net_device *dev, const unsigned char *addr, · 2014 unmodified lines
4288 unsigned char addr_type);4292 unsigned char addr_type);
4289void dev_addr_flush(struct net_device *dev);4293void dev_addr_flush(struct net_device *dev);
4290int dev_addr_init(struct net_device *dev);4294int dev_addr_init(struct net_device *dev);
4295void dev_addr_check(struct net_device *dev);
4291 4296
4292/* Functions used for unicast addresses handling */4297/* Functions used for unicast addresses handling */
4293int dev_uc_add(struct net_device *dev, const unsigned char *addr);4298int dev_uc_add(struct net_device *dev, const unsigned char *addr);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t