History

dev_addr: add a modification check

netdev->dev_addr should only be modified via helpers, but someone may be casting off the const. Add a runtime check to catch abuses.

Jakub Kicinski committed 4 years ago

Commit d07b26f1 parent 5f0b6923 files · +25 −0Browse files

Showing the changes to include (1 of 3 files). Show all

Unified · Split

include/linux/netdevice.h+5−0
@@ -1942,6 +1942,8 @@ enum netdev_ml_priv_type { · 1941 unmodified lines
19421942 * @unlink_list: As netif_addr_lock() can be called recursively,
19431943 * keep a list of interfaces to be deleted.
19441944 *
1945+ * @dev_addr_shadow: Copy of @dev_addr to catch direct writes.
1946+ *
19451947 * FIXME: cleanup struct net_device such that network protocol info
19461948 * moves out.
19471949 */
@@ -2268,6 +2270,8 @@ struct net_device { · 320 unmodified lines
22682270
22692271 /* protected by rtnl_lock */
22702272 struct bpf_xdp_entity xdp_state[__MAX_XDP_MODE];
2273+
2274+ u8 dev_addr_shadow[MAX_ADDR_LEN];
22712275 };
22722276 #define to_net_dev(d) container_of(d, struct net_device, dev)
22732277
@@ -4288,6 +4292,7 @@ int dev_addr_del(struct net_device *dev, const unsigned char *addr, · 2014 unmodified lines
42884292 unsigned char addr_type);
42894293 void dev_addr_flush(struct net_device *dev);
42904294 int dev_addr_init(struct net_device *dev);
4295+void dev_addr_check(struct net_device *dev);
42914296
42924297 /* Functions used for unicast addresses handling */
42934298 int dev_uc_add(struct net_device *dev, const unsigned char *addr);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t