Pull tracing/probes fix from Masami Hiramatsu: "Fix the eprobe event parser to point error position correctly" * tag 'probes-fixes-v7.1-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace: tracing/probes: Point the error offset correctly for eprobe argument error
Unified · Split
| @@ -962,8 +962,6 @@ static int parse_probe_vars(char *orig_arg, const struct fetch_type *t, · 961 unmodified lines | |||
| 962 | code->op = FETCH_OP_COMM; | 962 | code->op = FETCH_OP_COMM; |
| 963 | return 0; | 963 | return 0; |
| 964 | } | 964 | } |
| 965 | /* backward compatibility */ | ||
| 966 | ctx->offset = 0; | ||
| 967 | goto inval; | 965 | goto inval; |
| 968 | } | 966 | } |
| 969 | 967 | ||
| @@ -20,7 +20,7 @@ check_error 'e:foo/^123456789012345678901234567890123456789012345678901234567890 · 19 unmodified lines | |||
| 20 | check_error 'e:foo/^bar.1 syscalls/sys_enter_openat' # BAD_EVENT_NAME | 20 | check_error 'e:foo/^bar.1 syscalls/sys_enter_openat' # BAD_EVENT_NAME |
| 21 | 21 | ||
| 22 | check_error 'e:foo/bar syscalls/sys_enter_openat arg=^dfd' # BAD_FETCH_ARG | 22 | check_error 'e:foo/bar syscalls/sys_enter_openat arg=^dfd' # BAD_FETCH_ARG |
| 23 | check_error 'e:foo/bar syscalls/sys_enter_openat ^arg=$foo' # BAD_ATTACH_ARG | 23 | check_error 'e:foo/bar syscalls/sys_enter_openat arg=^$foo' # BAD_ATTACH_ARG |
| 24 | 24 | ||
| 25 | if grep -q '<attached-group>\.<attached-event>.*\[if <filter>\]' README; then | 25 | if grep -q '<attached-group>\.<attached-event>.*\[if <filter>\]' README; then |
| 26 | check_error 'e:foo/bar syscalls/sys_enter_openat if ^' # NO_EP_FILTER | 26 | check_error 'e:foo/bar syscalls/sys_enter_openat if ^' # NO_EP_FILTER |