History

drm/amdkfd: bump kfd ioctl minor version for event age availability

Bump the minor version to declare event age tracking feature is now available. In kernel amdgpu driver, kfd_wait_on_events is used to support user space signal event wait function. For multiple threads waiting on same event scenery, race condition could occur since some threads after checking signal condition, before calling kfd_wait_on_events, the event interrupt could be fired and wake up other thread which are sleeping on this event. Then those threads could fall into sleep without waking up again. Adding event age tracking in both kernel and user mode, will help avoiding this race condition. Proposed ROCT-Thunk-Interface: https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/commit/efdbf6cfbc026bd68ac3c35d00dacf84370eb81e https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/commit/1820ae0a2db85b6f584611dc0cde1a00e7c22915 Proposed ROCR-Runtime: https://github.com/RadeonOpenCompute/ROCR-Runtime/compare/master...zhums:ROCR-Runtime:new_event_wait_review https://github.com/RadeonOpenCompute/ROCR-Runtime/commit/e1f5bdb88eb882ac798aeca2c00ea3fbb2dba459 https://github.com/RadeonOpenCompute/ROCR-Runtime/commit/7d26afd14107b5c2a754c1a3f415d89f3aabb503

James Zhu committed 3 years ago

Commit d297eed1 parent 973fdde1 file · +2 −1Browse files

Unified · Split

include/uapi/linux/kfd_ioctl.h+2−1
@@ -39,9 +39,10 @@ · 38 unmodified lines
3939 * - 1.11 - Add unified memory for ctx save/restore area
4040 * - 1.12 - Add DMA buf export ioctl
4141 * - 1.13 - Add debugger API
42+ * - 1.14 - Update kfd_event_data
4243 */
4344 #define KFD_IOCTL_MAJOR_VERSION 1
44−#define KFD_IOCTL_MINOR_VERSION 13
45+#define KFD_IOCTL_MINOR_VERSION 14
4546
4647 struct kfd_ioctl_get_version_args {
4748 __u32 major_version; /* from KFD */

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t