History

RDMA/cxgb4: Mark QP in error before disabling the queue in firmware

QPs need to be moved to error before telling the firwmare to shutdown the queue. Otherwise, the application can submit WRs that will never get fetched by the hardware and never flushed by the driver.

Tom Tucker committed 15 years ago

Commit d32ae391 parent 581bbe21 file · +4 −0Browse files

Unified · Split

drivers/infiniband/hw/cxgb4/qp.c+4−0
@@ -1221,6 +1221,8 @@ int c4iw_modify_qp(struct c4iw_dev *rhp, struct c4iw_qp *qhp, · 1220 unmodified lines
12211221 disconnect = 1;
12221222 c4iw_get_ep(&qhp->ep->com);
12231223 }
1224+ if (qhp->ibqp.uobject)
1225+ t4_set_wq_in_error(&qhp->wq);
12241226 ret = rdma_fini(rhp, qhp, ep);
12251227 if (ret)
12261228 goto err;
@@ -1237,6 +1239,8 @@ int c4iw_modify_qp(struct c4iw_dev *rhp, struct c4iw_qp *qhp, · 10 unmodified lines
12371239 break;
12381240 case C4IW_QP_STATE_ERROR:
12391241 set_state(qhp, C4IW_QP_STATE_ERROR);
1242+ if (qhp->ibqp.uobject)
1243+ t4_set_wq_in_error(&qhp->wq);
12401244 if (!internal) {
12411245 abort = 1;
12421246 disconnect = 1;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t