History

markers: fix duplicate modpost entry

When a kernel was rebuilt, the previous Module.markers was not cleared. It caused markers with different format strings to appear as duplicates when a markers was changed. This problem is present since scripts/mod/modpost.c started to generate Module.markers, commit b2e3e658b344c6bcfb8fb694100ab2f2b5b2edb0 It therefore applies to 2.6.25, 2.6.26 and linux-next. I merely merged the patches from Roland, Wenji and Takashi here. Credits to Roland McGrath <roland@redhat.com> Wenji Huang <wenji.huang@oracle.com> and Takashi Nishiie <t-nishiie@np.css.fujitsu.com> for providing the individual fixes. - Changelog : - Integrated Takashi's Makefile modification to clear Module.markers upon make clean.

Mathieu Desnoyers committed 18 years ago

Commit d35cb361 parent 5f171563 files · +5 −2Browse files

Showing the changes to scripts (2 of 3 files). Show all

Unified · Split

2 files
  1. scripts/Makefile.modpost +1 −0
  2. scripts/mod/modpost.c +2 −1
scripts/Makefile.modpost+1−0
@@ -101,6 +101,7 @@ quiet_cmd_kernel-mod = MODPOST $@ · 100 unmodified lines
101101 cmd_kernel-mod = $(modpost) $@
102102
103103 vmlinux.o: FORCE
104+ @rm -fr $(kernelmarkersfile)
104105 $(call cmd,kernel-mod)
105106
106107 # Declare generated files as targets for modpost
scripts/mod/modpost.c+2−1
@@ -1992,7 +1992,8 @@ static void read_markers(const char *fname) · 1991 unmodified lines
19921992 mod->skip = 1;
19931993 }
19941994
1995− add_marker(mod, marker, fmt);
1995+ if (!mod->skip)
1996+ add_marker(mod, marker, fmt);
19961997 }
19971998 return;
19981999 fail:

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t