Since we removed cmd_type, we now have a hole in the struct. Move the internal_tag member to the same cacheline as tag, since we use them at the same time. This doesn't fix the hole, just moves it elsewhere.
Showing the changes to include/linux/blkdev.h (1 of 1 file). Show all
Unified · Split
| @@ -138,6 +138,9 @@ struct request { · 137 unmodified lines | |||
| 138 | int cpu; | 138 | int cpu; |
| 139 | unsigned int cmd_flags; /* op and common flags */ | 139 | unsigned int cmd_flags; /* op and common flags */ |
| 140 | req_flags_t rq_flags; | 140 | req_flags_t rq_flags; |
| 141 | |||
| 142 | int internal_tag; | ||
| 143 | |||
| 141 | unsigned long atomic_flags; | 144 | unsigned long atomic_flags; |
| 142 | 145 | ||
| 143 | /* the following two fields are internal, NEVER access directly */ | 146 | /* the following two fields are internal, NEVER access directly */ |
| @@ -209,8 +212,6 @@ struct request { · 65 unmodified lines | |||
| 209 | 212 | ||
| 210 | unsigned short ioprio; | 213 | unsigned short ioprio; |
| 211 | 214 | ||
| 212 | int internal_tag; | ||
| 213 | |||
| 214 | void *special; /* opaque pointer available for LLD use */ | 215 | void *special; /* opaque pointer available for LLD use */ |
| 215 | 216 | ||
| 216 | int errors; | 217 | int errors; |