History

x86,objtool: Mark cpu_startup_entry() __noreturn

GCC-8 isn't clever enough to figure out that cpu_start_entry() is a noreturn while objtool is. This results in code after the call in start_secondary(). Give GCC a hand so that they all agree on things. vmlinux.o: warning: objtool: start_secondary()+0x10e: unreachable

Peter Zijlstra committed 4 years ago

Commit d4e52681 parent 2730d3c2 files · +2 −1Browse files

Showing the changes to include (1 of 2 files). Show all

Unified · Split

include/linux/cpu.h+1−1
@@ -167,7 +167,7 @@ static inline int suspend_disable_secondary_cpus(void) { return 0; } · 166 unmodified lines
167167 static inline void suspend_enable_secondary_cpus(void) { }
168168 #endif /* !CONFIG_PM_SLEEP_SMP */
169169
170−void cpu_startup_entry(enum cpuhp_state state);
170+void __noreturn cpu_startup_entry(enum cpuhp_state state);
171171
172172 void cpu_idle_poll_ctrl(bool enable);
173173

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t