History

net/smc: retain old name for diag_mode field

Commit c601171d7a60 ("net/smc: provide smc mode in smc_diag.c") changed the name of diag_fallback field of struct smc_diag_msg structure to diag_mode. However, this structure is a part of UAPI, and this change breaks user space applications that use it ([1], for example). Since the new name is more suitable, convert the field to a union that provides access to the data via both the new and the old name. [1] https://gitlab.com/strace/strace/blob/v4.24/netlink_smc_diag.c#L165

Eugene Syromiatnikov committed 8 years ago

Commit d4f00061 parent a21048c1 file · +4 −1Browse files

Showing the changes to include/uapi/linux (1 of 1 file). Show all

Unified · Split

include/uapi/linux/smc_diag.h+4−1
@@ -20,7 +20,10 @@ struct smc_diag_req { · 19 unmodified lines
20struct smc_diag_msg {20struct smc_diag_msg {
21 __u8 diag_family;21 __u8 diag_family;
22 __u8 diag_state;22 __u8 diag_state;
23 __u8 diag_mode;23 union {
24 __u8 diag_mode;
25 __u8 diag_fallback; /* the old name of the field */
26 };
24 __u8 diag_shutdown;27 __u8 diag_shutdown;
25 struct inet_diag_sockid id;28 struct inet_diag_sockid id;
26 29

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t