kernel/sysctl.c is a kitchen sink where everyone leaves their dirty dishes, this makes it very difficult to maintain. To help with this maintenance let's start by moving sysctls to places where they actually belong. The proc sysctl maintainers do not want to know what sysctl knobs you wish to add for your own piece of code, we just care about the core logic. All filesystem syctls now get reviewed by fs folks. This commit follows the commit of fs, move the real_root_dev sysctl to its own file, kernel/do_mount_initrd.c.
Unified · Split
| @@ -29,8 +29,6 @@ static inline void wait_for_initramfs(void) {} · 28 unmodified lines | |||
| 29 | extern phys_addr_t phys_initrd_start; | 29 | extern phys_addr_t phys_initrd_start; |
| 30 | extern unsigned long phys_initrd_size; | 30 | extern unsigned long phys_initrd_size; |
| 31 | 31 | ||
| 32 | extern unsigned int real_root_dev; | ||
| 33 | |||
| 34 | extern char __initramfs_start[]; | 32 | extern char __initramfs_start[]; |
| 35 | extern unsigned long __initramfs_size; | 33 | extern unsigned long __initramfs_size; |
| 36 | 34 | ||
| @@ -14,12 +14,32 @@ · 13 unmodified lines | |||
| 14 | 14 | ||
| 15 | unsigned long initrd_start, initrd_end; | 15 | unsigned long initrd_start, initrd_end; |
| 16 | int initrd_below_start_ok; | 16 | int initrd_below_start_ok; |
| 17 | unsigned int real_root_dev; /* do_proc_dointvec cannot handle kdev_t */ | 17 | static unsigned int real_root_dev; /* do_proc_dointvec cannot handle kdev_t */ |
| 18 | static int __initdata mount_initrd = 1; | 18 | static int __initdata mount_initrd = 1; |
| 19 | 19 | ||
| 20 | phys_addr_t phys_initrd_start __initdata; | 20 | phys_addr_t phys_initrd_start __initdata; |
| 21 | unsigned long phys_initrd_size __initdata; | 21 | unsigned long phys_initrd_size __initdata; |
| 22 | 22 | ||
| 23 | #ifdef CONFIG_SYSCTL | ||
| 24 | static struct ctl_table kern_do_mounts_initrd_table[] = { | ||
| 25 | { | ||
| 26 | .procname = "real-root-dev", | ||
| 27 | .data = &real_root_dev, | ||
| 28 | .maxlen = sizeof(int), | ||
| 29 | .mode = 0644, | ||
| 30 | .proc_handler = proc_dointvec, | ||
| 31 | }, | ||
| 32 | { } | ||
| 33 | }; | ||
| 34 | |||
| 35 | static __init int kernel_do_mounts_initrd_sysctls_init(void) | ||
| 36 | { | ||
| 37 | register_sysctl_init("kernel", kern_do_mounts_initrd_table); | ||
| 38 | return 0; | ||
| 39 | } | ||
| 40 | late_initcall(kernel_do_mounts_initrd_sysctls_init); | ||
| 41 | #endif /* CONFIG_SYSCTL */ | ||
| 42 | |||
| 23 | static int __init no_initrd(char *str) | 43 | static int __init no_initrd(char *str) |
| 24 | { | 44 | { |
| 25 | mount_initrd = 0; | 45 | mount_initrd = 0; |
| @@ -1693,15 +1693,6 @@ static struct ctl_table kern_table[] = { · 1692 unmodified lines | |||
| 1693 | .mode = 0644, | 1693 | .mode = 0644, |
| 1694 | .proc_handler = sysctl_latencytop, | 1694 | .proc_handler = sysctl_latencytop, |
| 1695 | }, | 1695 | }, |
| 1696 | #endif | ||
| 1697 | #ifdef CONFIG_BLK_DEV_INITRD | ||
| 1698 | { | ||
| 1699 | .procname = "real-root-dev", | ||
| 1700 | .data = &real_root_dev, | ||
| 1701 | .maxlen = sizeof(int), | ||
| 1702 | .mode = 0644, | ||
| 1703 | .proc_handler = proc_dointvec, | ||
| 1704 | }, | ||
| 1705 | #endif | 1696 | #endif |
| 1706 | { | 1697 | { |
| 1707 | .procname = "print-fatal-signals", | 1698 | .procname = "print-fatal-signals", |