Pull NVMe fixes from Christoph: "A trivial one-liner from Martin to fix the visible of the uuid attr, and another one (originally from Abhishek Shah, rewritten by me) to fix the CMB addresses passed back to the controller in case of a system that remaps BAR addresses between host and device."
Unified · Split
| @@ -2136,7 +2136,7 @@ static umode_t nvme_ns_attrs_are_visible(struct kobject *kobj, · 2135 unmodified lines | |||
| 2136 | struct nvme_ns *ns = nvme_get_ns_from_dev(dev); | 2136 | struct nvme_ns *ns = nvme_get_ns_from_dev(dev); |
| 2137 | 2137 | ||
| 2138 | if (a == &dev_attr_uuid.attr) { | 2138 | if (a == &dev_attr_uuid.attr) { |
| 2139 | if (uuid_is_null(&ns->uuid) || | 2139 | if (uuid_is_null(&ns->uuid) && |
| 2140 | !memchr_inv(ns->nguid, 0, sizeof(ns->nguid))) | 2140 | !memchr_inv(ns->nguid, 0, sizeof(ns->nguid))) |
| 2141 | return 0; | 2141 | return 0; |
| 2142 | } | 2142 | } |
| @@ -94,7 +94,7 @@ struct nvme_dev { · 93 unmodified lines | |||
| 94 | struct mutex shutdown_lock; | 94 | struct mutex shutdown_lock; |
| 95 | bool subsystem; | 95 | bool subsystem; |
| 96 | void __iomem *cmb; | 96 | void __iomem *cmb; |
| 97 | dma_addr_t cmb_dma_addr; | 97 | pci_bus_addr_t cmb_bus_addr; |
| 98 | u64 cmb_size; | 98 | u64 cmb_size; |
| 99 | u32 cmbsz; | 99 | u32 cmbsz; |
| 100 | u32 cmbloc; | 100 | u32 cmbloc; |
| @@ -1226,7 +1226,7 @@ static int nvme_alloc_sq_cmds(struct nvme_dev *dev, struct nvme_queue *nvmeq, · 1125 unmodified lines | |||
| 1226 | if (qid && dev->cmb && use_cmb_sqes && NVME_CMB_SQS(dev->cmbsz)) { | 1226 | if (qid && dev->cmb && use_cmb_sqes && NVME_CMB_SQS(dev->cmbsz)) { |
| 1227 | unsigned offset = (qid - 1) * roundup(SQ_SIZE(depth), | 1227 | unsigned offset = (qid - 1) * roundup(SQ_SIZE(depth), |
| 1228 | dev->ctrl.page_size); | 1228 | dev->ctrl.page_size); |
| 1229 | nvmeq->sq_dma_addr = dev->cmb_dma_addr + offset; | 1229 | nvmeq->sq_dma_addr = dev->cmb_bus_addr + offset; |
| 1230 | nvmeq->sq_cmds_io = dev->cmb + offset; | 1230 | nvmeq->sq_cmds_io = dev->cmb + offset; |
| 1231 | } else { | 1231 | } else { |
| 1232 | nvmeq->sq_cmds = dma_alloc_coherent(dev->dev, SQ_SIZE(depth), | 1232 | nvmeq->sq_cmds = dma_alloc_coherent(dev->dev, SQ_SIZE(depth), |
| @@ -1527,7 +1527,7 @@ static void __iomem *nvme_map_cmb(struct nvme_dev *dev) · 294 unmodified lines | |||
| 1527 | resource_size_t bar_size; | 1527 | resource_size_t bar_size; |
| 1528 | struct pci_dev *pdev = to_pci_dev(dev->dev); | 1528 | struct pci_dev *pdev = to_pci_dev(dev->dev); |
| 1529 | void __iomem *cmb; | 1529 | void __iomem *cmb; |
| 1530 | dma_addr_t dma_addr; | 1530 | int bar; |
| 1531 | 1531 | ||
| 1532 | dev->cmbsz = readl(dev->bar + NVME_REG_CMBSZ); | 1532 | dev->cmbsz = readl(dev->bar + NVME_REG_CMBSZ); |
| 1533 | if (!(NVME_CMB_SZ(dev->cmbsz))) | 1533 | if (!(NVME_CMB_SZ(dev->cmbsz))) |
| @@ -1540,7 +1540,8 @@ static void __iomem *nvme_map_cmb(struct nvme_dev *dev) · 6 unmodified lines | |||
| 1540 | szu = (u64)1 << (12 + 4 * NVME_CMB_SZU(dev->cmbsz)); | 1540 | szu = (u64)1 << (12 + 4 * NVME_CMB_SZU(dev->cmbsz)); |
| 1541 | size = szu * NVME_CMB_SZ(dev->cmbsz); | 1541 | size = szu * NVME_CMB_SZ(dev->cmbsz); |
| 1542 | offset = szu * NVME_CMB_OFST(dev->cmbloc); | 1542 | offset = szu * NVME_CMB_OFST(dev->cmbloc); |
| 1543 | bar_size = pci_resource_len(pdev, NVME_CMB_BIR(dev->cmbloc)); | 1543 | bar = NVME_CMB_BIR(dev->cmbloc); |
| 1544 | bar_size = pci_resource_len(pdev, bar); | ||
| 1544 | 1545 | ||
| 1545 | if (offset > bar_size) | 1546 | if (offset > bar_size) |
| 1546 | return NULL; | 1547 | return NULL; |
| @@ -1553,12 +1554,11 @@ static void __iomem *nvme_map_cmb(struct nvme_dev *dev) · 6 unmodified lines | |||
| 1553 | if (size > bar_size - offset) | 1554 | if (size > bar_size - offset) |
| 1554 | size = bar_size - offset; | 1555 | size = bar_size - offset; |
| 1555 | 1556 | ||
| 1556 | dma_addr = pci_resource_start(pdev, NVME_CMB_BIR(dev->cmbloc)) + offset; | 1557 | cmb = ioremap_wc(pci_resource_start(pdev, bar) + offset, size); |
| 1557 | cmb = ioremap_wc(dma_addr, size); | ||
| 1558 | if (!cmb) | 1558 | if (!cmb) |
| 1559 | return NULL; | 1559 | return NULL; |
| 1560 | 1560 | ||
| 1561 | dev->cmb_dma_addr = dma_addr; | 1561 | dev->cmb_bus_addr = pci_bus_address(pdev, bar) + offset; |
| 1562 | dev->cmb_size = size; | 1562 | dev->cmb_size = size; |
| 1563 | return cmb; | 1563 | return cmb; |
| 1564 | } | 1564 | } |