History

usb: cdc-wdm: Fix race between disconnect and debug messages

dev_dbg() and dev_err() cannot be used to report failures that may have been caused by a device's removal

Oliver Neukum committed 16 years ago

Commit d855fe21 parent 922a5ea1 file · +0 −5Browse files

Unified · Split

drivers/usb/class/cdc-wdm.c+0−5
@@ -435,11 +435,8 @@ retry: · 434 unmodified lines
435 spin_lock_irq(&desc->iuspin);435 spin_lock_irq(&desc->iuspin);
436 436
437 if (desc->rerr) { /* read completed, error happened */437 if (desc->rerr) { /* read completed, error happened */
438 int t = desc->rerr;
439 desc->rerr = 0;438 desc->rerr = 0;
440 spin_unlock_irq(&desc->iuspin);439 spin_unlock_irq(&desc->iuspin);
441 dev_err(&desc->intf->dev,
442 "reading had resulted in %d\n", t);
443 rv = -EIO;440 rv = -EIO;
444 goto err;441 goto err;
445 }442 }
@@ -477,8 +474,6 @@ retry: · 31 unmodified lines
477 474
478err:475err:
479 mutex_unlock(&desc->lock);476 mutex_unlock(&desc->lock);
480 if (rv < 0 && rv != -EAGAIN)
481 dev_err(&desc->intf->dev, "wdm_read: exit error\n");
482 return rv;477 return rv;
483}478}
484 479

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t