History

platform/x86: asus-wmi: fix TUF laptop RGB variant

In kbd_rgb_mode_store the dev_get_drvdata() call was assuming the device data was asus_wmi when it was actually led_classdev. This patch corrects this by making the correct chain of calls to get the asus_wmi driver data.

Luke D. Jones committed 2 years ago

Commit d8b17a31 parent 182c6941 file · +5 −1Browse files

Unified · Split

drivers/platform/x86/asus-wmi.c+5−1
@@ -880,10 +880,14 @@ static ssize_t kbd_rgb_mode_store(struct device *dev, · 879 unmodified lines
880 struct device_attribute *attr,880 struct device_attribute *attr,
881 const char *buf, size_t count)881 const char *buf, size_t count)
882{882{
883 struct asus_wmi *asus = dev_get_drvdata(dev);
884 u32 cmd, mode, r, g, b, speed;883 u32 cmd, mode, r, g, b, speed;
884 struct led_classdev *led;
885 struct asus_wmi *asus;
885 int err;886 int err;
886 887
888 led = dev_get_drvdata(dev);
889 asus = container_of(led, struct asus_wmi, kbd_led);
890
887 if (sscanf(buf, "%d %d %d %d %d %d", &cmd, &mode, &r, &g, &b, &speed) != 6)891 if (sscanf(buf, "%d %d %d %d %d %d", &cmd, &mode, &r, &g, &b, &speed) != 6)
888 return -EINVAL;892 return -EINVAL;
889 893

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t