History

kbuild: do not remove empty *.symtypes explicitly

Presumably, 'test -s $@ || rm -f $@' intends to remove the output when the genksyms command fails. It is unneeded because .DELETE_ON_ERROR automatically removes the output on failure.

Masahiro Yamada committed 4 years ago

Commit dc6dc3e1 parent f43e31d1 file · +2 −6Browse files

Showing the changes to scripts (1 of 1 file). Show all

Unified · Split

scripts/Makefile.build+2−6
@@ -135,9 +135,7 @@ genksyms = scripts/genksyms/genksyms \ · 134 unmodified lines
135cmd_gensymtypes_c = $(CPP) -D__GENKSYMS__ $(c_flags) $< | $(genksyms)135cmd_gensymtypes_c = $(CPP) -D__GENKSYMS__ $(c_flags) $< | $(genksyms)
136 136
137quiet_cmd_cc_symtypes_c = SYM $(quiet_modtag) $@137quiet_cmd_cc_symtypes_c = SYM $(quiet_modtag) $@
138cmd_cc_symtypes_c = \138 cmd_cc_symtypes_c = $(call cmd_gensymtypes_c,true,$@) >/dev/null
139 $(call cmd_gensymtypes_c,true,$@) >/dev/null; \
140 test -s $@ || rm -f $@
141 139
142$(obj)/%.symtypes : $(src)/%.c FORCE140$(obj)/%.symtypes : $(src)/%.c FORCE
143 $(call cmd,cc_symtypes_c)141 $(call cmd,cc_symtypes_c)
@@ -348,9 +346,7 @@ cmd_gensymtypes_S = \ · 204 unmodified lines
348 $(CPP) -D__GENKSYMS__ $(c_flags) -xc - | $(genksyms)346 $(CPP) -D__GENKSYMS__ $(c_flags) -xc - | $(genksyms)
349 347
350quiet_cmd_cc_symtypes_S = SYM $(quiet_modtag) $@348quiet_cmd_cc_symtypes_S = SYM $(quiet_modtag) $@
351cmd_cc_symtypes_S = \349 cmd_cc_symtypes_S = $(call cmd_gensymtypes_S,true,$@) >/dev/null
352 $(call cmd_gensymtypes_S,true,$@) >/dev/null; \
353 test -s $@ || rm -f $@
354 350
355$(obj)/%.symtypes : $(src)/%.S FORCE351$(obj)/%.symtypes : $(src)/%.S FORCE
356 $(call cmd,cc_symtypes_S)352 $(call cmd,cc_symtypes_S)