[PATCH] gfp flags annotations - part 1

- added typedef unsigned int __nocast gfp_t; - replaced __nocast uses for gfp flags with gfp_t - it gives exactly the same warnings as far as sparse is concerned, doesn't change generated code (from gcc point of view we replaced unsigned int with typedef) and documents what's going on far better.

Al Viro committed 21 years ago

Commit dd0fc661 parent 3b0e77b145 files · +340 −360Browse files

Showing the changes to kernel (4 of 145 files). Show all

Unified · Split

4 files

kernel/audit.c +1 −1
kernel/cpuset.c +1 −1
kernel/kfifo.c +2 −2
kernel/signal.c +1 −1

kernel/audit.c+1−1

@@ -560,7 +560,7 @@ static void audit_buffer_free(struct audit_buffer *ab) · 559 unmodified lines
560	560	}
561	561
562	562	static struct audit_buffer * audit_buffer_alloc(struct audit_context *ctx,
563		− unsigned int __nocast gfp_mask, int type)
	563	+ gfp_t gfp_mask, int type)
564	564	{
565	565	unsigned long flags;
566	566	struct audit_buffer *ab = NULL;

kernel/cpuset.c+1−1

@@ -1670,7 +1670,7 @@ static const struct cpuset nearest_exclusive_ancestor(const struct cpuset cs) · 1669 unmodified lines
1670	1670	* GFP_USER - only nodes in current tasks mems allowed ok.
1671	1671	**/
1672	1672
1673		−int cpuset_zone_allowed(struct zone *z, unsigned int __nocast gfp_mask)
	1673	+int cpuset_zone_allowed(struct zone *z, gfp_t gfp_mask)
1674	1674	{
1675	1675	int node; /* node that zone z is on */
1676	1676	const struct cpuset cs; / current cpuset ancestors */

kernel/kfifo.c+2−2

@@ -36,7 +36,7 @@ · 35 unmodified lines
36	36	* struct kfifo with kfree().
37	37	*/
38	38	struct kfifo kfifo_init(unsigned char buffer, unsigned int size,
39		− unsigned int __nocast gfp_mask, spinlock_t *lock)
	39	+ gfp_t gfp_mask, spinlock_t *lock)
40	40	{
41	41	struct kfifo *fifo;
42	42
@@ -64,7 +64,7 @@ EXPORT_SYMBOL(kfifo_init); · 21 unmodified lines
64	64	*
65	65	* The size will be rounded-up to a power of 2.
66	66	*/
67		−struct kfifo kfifo_alloc(unsigned int size, unsigned int __nocast gfp_mask, spinlock_t lock)
	67	+struct kfifo kfifo_alloc(unsigned int size, gfp_t gfp_mask, spinlock_t lock)
68	68	{
69	69	unsigned char *buffer;
70	70	struct kfifo *ret;

kernel/signal.c+1−1

@@ -262,7 +262,7 @@ next_signal(struct sigpending pending, sigset_t mask) · 261 unmodified lines
262	262	return sig;
263	263	}
264	264
265		−static struct sigqueue __sigqueue_alloc(struct task_struct t, unsigned int __nocast flags,
	265	+static struct sigqueue __sigqueue_alloc(struct task_struct t, gfp_t flags,
266	266	int override_rlimit)
267	267	{
268	268	struct sigqueue *q = NULL;

[PATCH] gfp flags annotations - part 1

Keyboard shortcuts

General

Issues and pull requests

Issues, pull requests and Inbox

Repository code